celsworth / lxp-bridge

A bridge to MQTT/InfluxDB/Postgres for communications with LuxPower inverters
MIT License
13 stars 15 forks source link

Simplify timesync config to appease HA #209

Closed celsworth closed 1 year ago

celsworth commented 1 year ago

Further to discission in #198

I think HA doesn't like the extra nesting of the timesync hash underneath scheduler, but it's largely unnecessary so I can simplify it like so.

This is a backwards-incompatible breaking change unfortunately, but timesync probably isn't widely used so I'm ok with it.

In summary, if you use the timesync you need to change this:

scheduler:
  enabled: true
  timesync:
    enabled: true
    cron: "0 0 * * *"

to this:

scheduler:
  enabled: true
  timesync_cron: "0 0 * * *"

The nested enabled has been dropped. The remaining enabled is for the entire scheduler, though timesync is the only thing it does at the moment.

jlwainwright commented 1 year ago

Hi Chris

Just to clarify.

Time sync will still not function using HA add-on even with yaml set like this:

scheduler: enabled: true timesync_cron: "0 0 *"

?

Still getting: lxp_bridge::scheduler] scheduler config not found, skipping

celsworth commented 1 year ago

Hi, are you using the latest dev Docker tag? It's not in the release version yet.

jlwainwright commented 1 year ago

Ok. Thanks for clarification Chris. This site is not running on a Docker environment. The site on docker is working fine in terms of syncing time using Dev branch. Will wait for it to make it to HA for the other site and test again then.


From: Chris Elsworth @.> Sent: Friday, October 20, 2023 5:06:24 PM To: celsworth/lxp-bridge @.> Cc: Skillet @.>; Comment @.> Subject: Re: [celsworth/lxp-bridge] Simplify timesync config to appease HA (PR #209)

Hi, are you using the latest dev Docker tag? It's not in the release version yet.

— Reply to this email directly, view it on GitHubhttps://github.com/celsworth/lxp-bridge/pull/209#issuecomment-1772916355, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEDHXQZOZ4I467ULFUJ4WWLYAKHPBAVCNFSM6AAAAAA6BAUVBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZSHEYTMMZVGU. You are receiving this because you commented.Message ID: @.***>