search

celtera / libremidi

A modern C++ MIDI 1 / MIDI 2 real-time & file I/O library. Supports Windows, macOS, Linux and WebMIDI.
Other
456 stars 51 forks source link

Example midifile_dump.cpp is missing math.h and iostream includes #113

Closed pissalou closed 2 months ago

pissalou commented 2 months ago

The example does not compile due to missing include math.h for pow() function. It is also missing iostream (mispelled istream).

jcelerier commented 2 months ago

strange, on which platform are you ? the CI builds the examples on pretty much every platform with every available compiler (https://github.com/celtera/libremidi/actions/runs/10288642249) and this hasn't come up as a build error

pissalou commented 2 months ago

I'm on ubuntu 23.04, cmake v3.25.1, make 4.3, gcc 12.3.0. This seems like this is an issue only on the 4.X branch, I forgot to mention.

jcelerier commented 2 months ago

ohh ok

jcelerier commented 2 months ago

pushed both fixes there