celtera / libremidi

A modern C++ MIDI 1 / MIDI 2 real-time & file I/O library. Supports Windows, macOS, Linux and WebMIDI.
Other
463 stars 51 forks source link

2 tests fail #72

Closed yurivict closed 1 year ago

yurivict commented 1 year ago

log

Version: 3.0 clang-15 FreeBSD 13.2

jcelerier commented 1 year ago

working on them.. I could fix the invalid midi parsing ones: https://github.com/jcelerier/libremidi/tree/v3

jcelerier commented 1 year ago

can you try this branch which should have all tests fixed? https://github.com/jcelerier/libremidi/tree/v4

and... do you know any way I could put freebsd CI in github actions?

yurivict commented 1 year ago

can you try this branch [...]

I will try this branch a bit later.

and... do you know any way I could put freebsd CI in github actions?

Does this answer your question?

yurivict commented 1 year ago

can you try this branch [...]

configure fails:

-- libremidi: Using std::vector for libremidi::message
-- libremidi: using ALSA
-- libremidi: using linked JACK
-- libremidi: compiling tests
CMake Error at CMakeLists.txt:360 (include):
  include could not find requested file:

    Catch

CMake Error at CMakeLists.txt:361 (catch_discover_tests):
  Unknown CMake command "catch_discover_tests".
jcelerier commented 1 year ago

I'm trying to add the VM, do you know how can I install boost and jack with pkg? https://github.com/jcelerier/libremidi/blob/v4/.github/workflows/build_cmake.yml#L127

otherwise I think the tests should be good

yurivict commented 1 year ago

[...] do you know how can I install boost and jack with pkg? [...]

$ sudo pkg install jackit boost-libs

This command searches for packages by name:

$ pkg search {name}
jcelerier commented 1 year ago

almost there... https://github.com/jcelerier/libremidi/actions/runs/5649349837/job/15303504636

yurivict commented 1 year ago

#!/bin/bash should be #!/usr/bin/env bash.

jcelerier commented 1 year ago

everything is green in CI :) https://github.com/jcelerier/libremidi/actions/runs/5649457339