search

celzero / firestack

Userspace wireguard and network monitor
https://rethinkdns.com/app
Mozilla Public License 2.0
100 stars 16 forks source link

NilAway: 96 nil ptrs (nov 23) #31

Closed ignoramous closed 1 year ago

ignoramous commented 1 year ago

96 nil ptrs detected by NilAway.

# go install go.uber.org/nilaway/cmd/nilaway@latest
# nilaway ./...

/home/murtaza/bravehub/firestack/intra/core/barrier.go:86:3: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> core/barrier.go:61:11: literal `nil` returned from `getLocked()` in position 0
    -> core/barrier.go:86:3: result 0 of `getLocked()` accessed field `wg`

(Same nil source could also cause potential nil panic(s) at 1 other place(s): core/barrier.go:85:3.)

/home/murtaza/bravehub/firestack/intra/dialers/retrier.go:166:23: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dialers/retrier.go:166:23: unassigned variable `neterr` called `Timeout()`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:110:2: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> xdns/dnsutil.go:81:10: literal `nil` returned from `EmptyResponseFromMessage()` in position 0
    -> xdns/dnsutil.go:110:2: result 0 of `EmptyResponseFromMessage()` accessed field `Truncated`

(Same nil source could also cause potential nil panic(s) at 5 other place(s): xdns/dnsutil.go:538:3, xdns/dnsutil.go:505:4, xdns/dnsutil.go:518:4, xdns/dnsutil.go:524:3, and xdns/dnsutil.go:483:2.)

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:395:23: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> xdns/dnsutil.go:395:23: literal `nil` assigned deeply into local variable `touched`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:368:20: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> xdns/dnsutil.go:368:20: literal `nil` assigned deeply into local variable `touched`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:652:29: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> xdns/dnsutil.go:652:29: literal `nil` assigned deeply into local variable `touched`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:685:29: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> xdns/dnsutil.go:685:29: literal `nil` assigned deeply into local variable `touched`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:1006:10: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> net/ip.go:498:9: literal `nil` returned from `ParseIP()` in position 0
    -> dns@v1.1.49/scan_rr.go:98:9: result 0 of `ParseIP()` assigned into field `A`
    -> xdns/dnsutil.go:1006:10: field `A` called `To4()`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:503:10: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> net/ip.go:498:9: literal `nil` returned from `ParseIP()` in position 0
    -> xdns/common.go:53:2: result 0 of `ParseIP()` assigned into global variable `ip4zero`
    -> xdns/dnsutil.go:503:10: global variable `ip4zero` called `To4()`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:516:13: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> net/ip.go:498:9: literal `nil` returned from `ParseIP()` in position 0
    -> xdns/common.go:54:2: result 0 of `ParseIP()` assigned into global variable `ip6zero`
    -> xdns/dnsutil.go:516:13: global variable `ip6zero` called `To16()`

/home/murtaza/bravehub/firestack/intra/dnsx/rethinkdns.go:562:17: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dnsx/rethinkdns.go:562:17: deep read from global variable `MaskBottom` lacking guarding; sliced into

/home/murtaza/bravehub/firestack/intra/dnsx/transport.go:179:16: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dnsx/cacher.go:92:10: literal `nil` returned from `NewCachingTransport()` in position 0
    -> dnsx/transport.go:179:16: result 0 of `NewCachingTransport()` called `ID()`

(Same nil source could also cause potential nil panic(s) at 1 other place(s): dnsx/transport.go:236:16.)

/home/murtaza/bravehub/firestack/intra/dnsx/transport.go:314:48: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dnsx/transport.go:314:48: deep read from field `transports` lacking guarding; called `ID()`

(Same nil source could also cause potential nil panic(s) at 1 other place(s): dnsx/transport.go:314:56.)

/home/murtaza/bravehub/firestack/intra/dnsx/transport.go:726:9: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> strings/strings.go:242:10: literal `nil` returned from `genSplit()` in position 0
    -> strings/strings.go:312:45: result 0 of `genSplit()` returned from `Split()` in position 0
    -> dnsx/transport.go:726:9: result 0 of `Split()` sliced into

(Same nil source could also cause potential nil panic(s) at 4 other place(s): dnsx/transport.go:728:14, dnsx/transport.go:728:20, dnsx/transport.go:731:14, and dnsx/transport.go:731:20.)

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:171:20: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dnsx/wall.go:144:10: literal `nil` returned from `blockA()` in position 0
    -> dnsx/transport.go:424:28: result 0 of `blockA()` passed as arg `msg` to `RTtl()`
    -> xdns/dnsutil.go:171:20: function parameter `msg` accessed field `Answer`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:171:20: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> xdns/dnsutil.go:81:10: literal `nil` returned from `EmptyResponseFromMessage()` in position 0
    -> xdns/dnsutil.go:489:3: result 0 of `EmptyResponseFromMessage()` returned from `RefusedResponseFromMessage()` via named return `dstMsg`
    -> dnsx/wall.go:168:2: result 0 of `RefusedResponseFromMessage()` returned from `blockA()` via named return `finalans`
    -> dnsx/transport.go:424:28: result 0 of `blockA()` passed as arg `msg` to `RTtl()`
    -> xdns/dnsutil.go:171:20: function parameter `msg` accessed field `Answer`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:171:20: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dnsx/wall.go:165:3: result 0 of `RefusedResponseFromMessage()` lacking guarding; returned from `blockA()` via named return `finalans`
    -> dnsx/transport.go:424:28: result 0 of `blockA()` passed as arg `msg` to `RTtl()`
    -> xdns/dnsutil.go:171:20: function parameter `msg` accessed field `Answer`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:171:20: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dnsx/wall.go:138:3: unassigned variable `finalans` returned from `blockA()` via named return `finalans`
    -> dnsx/transport.go:424:28: result 0 of `blockA()` passed as arg `msg` to `RTtl()`
    -> xdns/dnsutil.go:171:20: function parameter `msg` accessed field `Answer`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:171:20: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dnsx/wall.go:159:3: unassigned variable `finalans` returned from `blockA()` via named return `finalans`
    -> dnsx/transport.go:424:28: result 0 of `blockA()` passed as arg `msg` to `RTtl()`
    -> xdns/dnsutil.go:171:20: function parameter `msg` accessed field `Answer`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:171:20: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dnsx/wall.go:154:3: unassigned variable `finalans` returned from `blockA()` via named return `finalans`
    -> dnsx/transport.go:424:28: result 0 of `blockA()` passed as arg `msg` to `RTtl()`
    -> xdns/dnsutil.go:171:20: function parameter `msg` accessed field `Answer`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:171:20: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dnsx/wall.go:149:3: unassigned variable `finalans` returned from `blockA()` via named return `finalans`
    -> dnsx/transport.go:424:28: result 0 of `blockA()` passed as arg `msg` to `RTtl()`
    -> xdns/dnsutil.go:171:20: function parameter `msg` accessed field `Answer`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:171:20: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dnsx/wall.go:129:4: unassigned variable `finalans` returned from `blockA()` via named return `finalans`
    -> dnsx/transport.go:424:28: result 0 of `blockA()` passed as arg `msg` to `RTtl()`
    -> xdns/dnsutil.go:171:20: function parameter `msg` accessed field `Answer`

/home/murtaza/bravehub/firestack/intra/dnsx/alg.go:196:48: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dnsx/transport.go:396:22: unassigned variable `t2` passed as arg `t2` to `q()`
    -> dnsx/alg.go:234:22: passed as parameter `t2` to `dnsgateway.q()` (implementing `Gateway.q()`)
    -> dnsx/alg.go:244:22: function parameter `t2` passed as arg `t2` to `querySecondary()`
    -> dnsx/alg.go:196:48: function parameter `t2` called `ID()`

/home/murtaza/bravehub/firestack/intra/ipn/h1/dialer.go:149:3: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dialers/tlsdial.go:64:11: unassigned variable `conn` returned from `tlsdial()` in position 0
    -> dialers/tlsdial.go:97:9: result 0 of `tlsdial()` returned from `TlsDial()` in position 0
    -> h1/dialer.go:107:9: result 0 of `TlsDial()` returned from `dialProxy()` in position 0
    -> h1/dialer.go:149:3: result 0 of `dialProxy()` called `Close()`

(Same nil source could also cause potential nil panic(s) at 3 other place(s): h1/dialer.go:143:4, h1/dialer.go:137:4, and h1/dialer.go:130:3.)

/home/murtaza/bravehub/firestack/intra/ipn/h1/dialer.go:171:15: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> strings/strings.go:242:10: literal `nil` returned from `genSplit()` in position 0
    -> strings/strings.go:283:53: result 0 of `genSplit()` returned from `SplitN()` in position 0
    -> h1/dialer.go:171:15: result 0 of `SplitN()` sliced into

/home/murtaza/bravehub/firestack/intra/ipn/wg/wgconn.go:126:30: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> net/udpsock.go:93:10: literal `nil` returned from `ResolveUDPAddr()` in position 0 when the error return in position 1 is not guaranteed to be non-nil through all paths
    -> wg/wgconn.go:126:30: result 0 of `ResolveUDPAddr()` accessed field `Port`

(Same nil source could also cause potential nil panic(s) at 1 other place(s): wg/wgconn2.go:148:30.)

/home/murtaza/bravehub/firestack/intra/ipn/wg/wgconn.go:117:11: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> net/iprawsock_posix.go:146:10: literal `nil` returned from `listenIP()` in position 0 when the error return in position 1 is not guaranteed to be non-nil through all paths
    -> net/dial.go:774:9: result 0 of `listenIP()` returned from `ListenPacket()` in position 0
    -> wg/wgconn.go:117:11: result 0 of `ListenPacket()` called `LocalAddr()`

(Same nil source could also cause potential nil panic(s) at 1 other place(s): wg/wgconn2.go:143:11.)

/home/murtaza/bravehub/firestack/intra/ipn/wg/wgconn.go:119:3: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> net/net.go:215:10: literal `nil` returned from `LocalAddr()` in position 0
    -> net/net.go:328:2: returned as result 0 from interface method `PacketConn.LocalAddr()` (implemented by `conn.LocalAddr()`)
    -> wg/wgconn.go:119:3: result 0 of `LocalAddr()` called `Network()`

(Same nil source could also cause potential nil panic(s) at 3 other place(s): wg/wgconn.go:120:3, wg/wgconn2.go:144:33, and wg/wgconn2.go:144:50.)

/home/murtaza/bravehub/firestack/intra/ipn/wg/wgconn.go:287:13: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> net/udpsock.go:130:10: literal `nil` returned from `SyscallConn()` in position 0 when the error return in position 1 is not guaranteed to be non-nil through all paths
    -> wg/wgconn.go:287:13: result 0 of `SyscallConn()` called `Control()`

(Same nil source could also cause potential nil panic(s) at 5 other place(s): wg/wgconn.go:278:13, wg/wgconn.go:305:8, wg/wgconn.go:322:8, wg/wgconn2.go:386:13, and wg/wgconn2.go:377:13.)

/home/murtaza/bravehub/firestack/intra/ipn/wg/wgconn.go:261:34: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> device/send.go:519:27: nilable value passed as arg `buffers` to `SendBuffers()`
    -> device/peer.go:126:35: function parameter `buffers` passed as arg `bufs` to `Send()`
    -> wg/wgconn.go:231:25: passed as parameter `buf` to `StdNetBind.Send()` (implementing `Bind.Send()`)
    -> wg/wgconn.go:261:34: function parameter `buf` sliced into

/home/murtaza/bravehub/firestack/intra/ipn/piph2.go:128:3: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> tls/common.go:829:10: literal `nil` returned from `Clone()` in position 0
    -> ipn/piph2.go:128:3: result 0 of `Clone()` accessed field `ServerName`

/home/murtaza/bravehub/firestack/intra/ipn/piph2.go:135:3: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dialers/rdial.go:89:11: unassigned variable `conn` returned from `commondial()` in position 0
    -> dialers/rdial.go:122:9: result 0 of `commondial()` returned from `SplitDial()` in position 0
    -> ipn/piph2.go:142:9: result 0 of `SplitDial()` returned from `dial()` in position 0
    -> ipn/piph2.go:135:3: result 0 of `dial()` called `Close()`

/home/murtaza/bravehub/firestack/intra/ipn/piph2.go:193:34: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> settings/config.go:247:11: literal `nil` returned from `NewAuthProxyOptions()` in position 0
    -> ipn/proxy.go:87:38: result 0 of `NewAuthProxyOptions()` passed as arg `po` to `NewPipProxy()`
    -> ipn/piph2.go:193:34: function parameter `po` accessed field `Addrs`

/home/murtaza/bravehub/firestack/intra/ipn/pipws.go:133:34: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> settings/config.go:247:11: literal `nil` returned from `NewAuthProxyOptions()` in position 0
    -> ipn/proxy.go:89:40: result 0 of `NewAuthProxyOptions()` passed as arg `po` to `NewPipWsProxy()`
    -> ipn/pipws.go:133:34: function parameter `po` accessed field `Addrs`

/home/murtaza/bravehub/firestack/intra/ipn/proxy.go:103:33: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> ipn/proxy.go:103:33: unassigned variable `p` called `ID()`

(Same nil source could also cause potential nil panic(s) at 2 other place(s): ipn/proxy.go:103:41, and ipn/proxy.go:103:51.)

/home/murtaza/bravehub/firestack/intra/ipn/proxies.go:145:7: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> ipn/proxy.go:99:26: unassigned variable `p` passed as arg `p` to `add()`
    -> ipn/proxies.go:149:17: function parameter `p` assigned deeply into field `p`
    -> ipn/proxies.go:145:7: deep read from field `p` called `Stop()`

/home/murtaza/bravehub/firestack/intra/ipn/wgnet.go:137:2: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> ipn/wgnet.go:137:2: result 0 of `Finish()` lacking guarding; sliced into

(Same nil source could also cause potential nil panic(s) at 2 other place(s): ipn/wgnet.go:136:2, and ipn/wgnet.go:134:11.)

/home/murtaza/bravehub/firestack/intra/ipn/wgnet.go:263:3: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> ipn/wgnet.go:263:3: result 0 of `DialUDPAddrPort()` lacking guarding; called `Close()`

(Same nil source could also cause potential nil panic(s) at 1 other place(s): ipn/wgnet.go:251:11.)

/home/murtaza/bravehub/firestack/intra/ipn/wgnet.go:180:13: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> ipn/wgnet.go:259:35: result 0 of `DialUDPAddrPort()` lacking guarding; passed as arg `c` to `dnsPacketRoundTrip()`
    -> ipn/wgnet.go:180:13: function parameter `c` called `Read()`

/home/murtaza/bravehub/firestack/intra/ipn/wgnet.go:263:3: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> ipn/wgnet.go:263:3: result 0 of `DialContextTCPAddrPort()` lacking guarding; called `Close()`

(Same nil source could also cause potential nil panic(s) at 1 other place(s): ipn/wgnet.go:251:11.)

/home/murtaza/bravehub/firestack/intra/ipn/wgnet.go:180:13: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> ipn/wgnet.go:259:35: result 0 of `DialContextTCPAddrPort()` lacking guarding; passed as arg `c` to `dnsPacketRoundTrip()`
    -> ipn/wgnet.go:180:13: function parameter `c` called `Read()`

/home/murtaza/bravehub/firestack/intra/ipn/wgnet.go:585:55: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> core/barrier.go:61:11: literal `nil` returned from `getLocked()` in position 0
    -> core/barrier.go:87:10: result 0 of `getLocked()` returned from `Do()` in position 0
    -> ipn/wgnet.go:585:55: result 0 of `Do()` accessed field `Val`

(Same nil source could also cause potential nil panic(s) at 4 other place(s): ipn/wgnet.go:583:18, ipn/wgnet.go:581:45, ipn/wgnet.go:580:49, and ipn/wgnet.go:579:5.)

/home/murtaza/bravehub/firestack/intra/ipn/wgnet.go:604:10: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> context/context.go:184:9: literal `nil` returned from `Done()` in position 0
    -> context/context.go:105:2: returned as result 0 from interface method `Context.Done()` (implemented by `emptyCtx.Done()`)
    -> ipn/wgnet.go:604:10: result 0 of `Done()` uninitialized; nil channel accessed

/home/murtaza/bravehub/firestack/intra/ipn/wgnet.go:862:17: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> stack/stack.go:781:10: literal `nil` returned from `NewEndpoint()` in position 0
    -> ipn/wgnet.go:862:17: result 0 of `NewEndpoint()` called `Connect()`

(Same nil source could also cause potential nil panic(s) at 1 other place(s): ipn/wgnet.go:854:17.)

/home/murtaza/bravehub/firestack/intra/ipn/wgnet.go:903:2: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> stack/stack.go:781:10: literal `nil` returned from `NewEndpoint()` in position 0
    -> ipn/wgnet.go:850:10: result 0 of `NewEndpoint()` assigned into field `ep`
    -> ipn/wgnet.go:903:2: field `ep` called `Close()`

(Same nil source could also cause potential nil panic(s) at 2 other place(s): ipn/wgnet.go:928:19, and ipn/wgnet.go:955:19.)

/home/murtaza/bravehub/firestack/intra/dns53/dot.go:130:3: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dns53/dot.go:130:3: result 0 of `addtls()` lacking guarding; called `Close()`

/home/murtaza/bravehub/firestack/intra/dns53/dot.go:122:17: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dns53/dot.go:122:17: unassigned variable `px` called `Dialer()`

(Same nil source could also cause potential nil panic(s) at 2 other place(s): dns53/dot.go:121:62, and dns53/dot.go:121:71.)

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:171:20: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> xdns/dnsutil.go:31:10: literal `nil` returned from `AsMsg()` in position 0
    -> dns53/dot.go:201:23: result 0 of `AsMsg()` passed as arg `msg` to `RTtl()`
    -> xdns/dnsutil.go:171:20: function parameter `msg` accessed field `Answer`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:171:20: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> xdns/dnsutil.go:31:10: literal `nil` returned from `AsMsg()` in position 0
    -> dns53/goos.go:169:23: result 0 of `AsMsg()` passed as arg `msg` to `RTtl()`
    -> xdns/dnsutil.go:171:20: function parameter `msg` accessed field `Answer`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:171:20: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dns53/grounded.go:56:27: result 0 of `BlockResponseFromMessage()` lacking guarding; passed as arg `msg` to `RTtl()`
    -> xdns/dnsutil.go:171:20: function parameter `msg` accessed field `Answer`

/home/murtaza/bravehub/firestack/intra/dns53/ipmapper.go:98:11: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> core/barrier.go:61:11: literal `nil` returned from `getLocked()` in position 0
    -> core/barrier.go:87:10: result 0 of `getLocked()` returned from `Do()` in position 0
    -> dns53/ipmapper.go:98:11: result 0 of `Do()` accessed field `Err`

(Same nil source could also cause potential nil panic(s) at 3 other place(s): dns53/ipmapper.go:95:11, dns53/ipmapper.go:97:11, and dns53/ipmapper.go:94:11.)

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:171:20: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dns53/mdns.go:124:9: literal `nil` returned from `oneshotQuery()` in position 0
    -> dns53/mdns.go:157:27: result 0 of `oneshotQuery()` passed as arg `msg` to `RTtl()`
    -> xdns/dnsutil.go:171:20: function parameter `msg` accessed field `Answer`

/home/murtaza/bravehub/firestack/intra/dns53/mdns.go:406:55: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dns53/mdns.go:406:55: unassigned variable `disco` accessed field `name`

/home/murtaza/bravehub/firestack/intra/dns53/upstream.go:150:30: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dns53/upstream.go:150:30: unassigned variable `px` called `Dialer()`

(Same nil source could also cause potential nil panic(s) at 2 other place(s): dns53/upstream.go:149:76, and dns53/upstream.go:149:85.)

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:171:20: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> xdns/dnsutil.go:31:10: literal `nil` returned from `AsMsg()` in position 0
    -> dns53/upstream.go:232:23: result 0 of `AsMsg()` passed as arg `msg` to `RTtl()`
    -> xdns/dnsutil.go:171:20: function parameter `msg` accessed field `Answer`

/home/murtaza/bravehub/firestack/intra/dnscrypt/crypto.go:57:11: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> secretbox/secretbox.go:127:10: literal `nil` returned from `Open()` in position 0
    -> dnscrypt/crypto.go:157:22: result 0 of `Open()` passed as arg `packet` to `unpad()`
    -> dnscrypt/crypto.go:57:11: function parameter `packet` sliced into

/home/murtaza/bravehub/firestack/intra/dnscrypt/intercept.go:201:2: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> xdns/dnsutil.go:81:10: literal `nil` returned from `EmptyResponseFromMessage()` in position 0
    -> dnscrypt/intercept.go:201:2: result 0 of `EmptyResponseFromMessage()` accessed field `Rcode`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:171:20: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> xdns/dnsutil.go:31:10: literal `nil` returned from `AsMsg()` in position 0
    -> dnscrypt/multiserver.go:315:23: result 0 of `AsMsg()` passed as arg `msg` to `RTtl()`
    -> xdns/dnsutil.go:171:20: function parameter `msg` accessed field `Answer`

/home/murtaza/bravehub/firestack/intra/dnsx/queryerror.go:43:9: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dnscrypt/multiserver.go:307:9: unassigned variable `qerr` used as receiver to call `Unwrap()`
    -> dnsx/queryerror.go:43:9: read by method receiver `e` accessed field `err`

/home/murtaza/bravehub/firestack/intra/dnsx/queryerror.go:47:9: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dnscrypt/multiserver.go:306:12: unassigned variable `qerr` used as receiver to call `Status()`
    -> dnsx/queryerror.go:47:9: read by method receiver `e` accessed field `status`

/home/murtaza/bravehub/firestack/intra/dnscrypt/multiserver.go:515:36: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> strings/strings.go:242:10: literal `nil` returned from `genSplit()` in position 0
    -> strings/strings.go:312:45: result 0 of `genSplit()` returned from `Split()` in position 0
    -> dnscrypt/multiserver.go:515:36: result 0 of `Split()` sliced into

(Same nil source could also cause potential nil panic(s) at 1 other place(s): dnscrypt/multiserver.go:514:10.)

/home/murtaza/bravehub/firestack/intra/dnscrypt/multiserver.go:323:22: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dnscrypt/servers.go:84:10: literal `nil` returned from `getOne()` in position 0
    -> dnscrypt/multiserver.go:535:31: result 0 of `getOne()` passed as arg `si` to `resolve()`
    -> dnscrypt/multiserver.go:323:22: function parameter `si` accessed field `relay`

/home/murtaza/bravehub/firestack/intra/dnscrypt/multiserver.go:323:22: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dnscrypt/servers.go:97:9: unassigned variable `serverInfo` returned from `getOne()` in position 0
    -> dnscrypt/multiserver.go:535:31: result 0 of `getOne()` passed as arg `si` to `resolve()`
    -> dnscrypt/multiserver.go:323:22: function parameter `si` accessed field `relay`

/home/murtaza/bravehub/firestack/intra/dnscrypt/servers.go:95:38: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dnscrypt/servers.go:95:38: unassigned variable `serverInfo` dereferenced

/home/murtaza/bravehub/firestack/intra/dnscrypt/multiserver.go:323:22: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dnscrypt/servers.go:152:28: result 0 of `fetchServerInfo()` lacking guarding; assigned deeply into field `inner`
    -> dnscrypt/servers.go:97:9: deep read from field `inner` returned from `getOne()` in position 0
    -> dnscrypt/multiserver.go:535:31: result 0 of `getOne()` passed as arg `si` to `resolve()`
    -> dnscrypt/multiserver.go:323:22: function parameter `si` accessed field `relay`

/home/murtaza/bravehub/firestack/intra/doh/doh.go:308:42: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> doh/doh.go:308:42: unassigned variable `px` called `ID()`

(Same nil source could also cause potential nil panic(s) at 1 other place(s): doh/doh.go:308:51.)

/home/murtaza/bravehub/firestack/intra/doh/doh.go:239:14: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> doh/doh.go:304:33: unassigned variable `px` passed as arg `p` to `httpClientFor()`
    -> doh/doh.go:239:14: function parameter `p` called `ID()`

/home/murtaza/bravehub/firestack/intra/doh/doh.go:399:8: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> http/client.go:644:12: unassigned variable `resp` returned from `do()` in position 0
    -> http/client.go:590:9: result 0 of `do()` returned from `Do()` in position 0
    -> doh/doh.go:312:9: result 0 of `Do()` returned from `fetch()` in position 0
    -> doh/doh.go:399:8: result 0 of `fetch()` accessed field `StatusCode`

(Same nil source could also cause potential nil panic(s) at 3 other place(s): doh/doh.go:397:13, doh/doh.go:393:2, and doh/doh.go:387:24.)

/home/murtaza/bravehub/firestack/intra/doh/doh.go:420:36: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> http/client.go:644:12: unassigned variable `resp` returned from `do()` in position 0
    -> http/client.go:590:9: result 0 of `do()` returned from `Do()` in position 0
    -> doh/doh.go:312:9: result 0 of `Do()` returned from `fetch()` in position 0
    -> doh/doh.go:414:32: result 0 of `fetch()` passed as arg `res` to `rdnsBlockstamp()`
    -> doh/doh.go:420:36: function parameter `res` accessed field `Header`

(Same nil source could also cause potential nil panic(s) at 1 other place(s): doh/doh.go:419:19.)

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:171:20: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> xdns/dnsutil.go:31:10: literal `nil` returned from `AsMsg()` in position 0
    -> doh/doh.go:470:23: result 0 of `AsMsg()` passed as arg `msg` to `RTtl()`
    -> xdns/dnsutil.go:171:20: function parameter `msg` accessed field `Answer`

/home/murtaza/bravehub/firestack/intra/doh/odoh.go:102:22: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> url/url.go:1116:9: result 0 of `ParseQuery()` lacking guarding; returned from `Query()` in position 0
    -> doh/odoh.go:102:22: result 0 of `Query()` called `Encode()`

(Same nil source could also cause potential nil panic(s) at 2 other place(s): doh/odoh.go:101:3, and doh/odoh.go:100:3.)

/home/murtaza/bravehub/firestack/intra/doh/odoh.go:183:31: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> http/client.go:644:12: unassigned variable `resp` returned from `do()` in position 0
    -> http/client.go:590:9: result 0 of `do()` returned from `Do()` in position 0
    -> doh/odoh.go:183:31: result 0 of `Do()` accessed field `Body`

/home/murtaza/bravehub/firestack/intra/netstack/fdbased.go:405:3: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> netstack/fdbased.go:250:18: literal `nil` assigned into field `dispatcher`
    -> netstack/fdbased.go:405:3: field `dispatcher` called `DeliverNetworkPacket()`

/home/murtaza/bravehub/firestack/intra/netstack/tcp.go:186:2: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> tcp/forwarder.go:155:10: literal `nil` returned from `CreateEndpoint()` in position 0
    -> netstack/tcp.go:119:10: result 0 of `CreateEndpoint()` assigned into field `ep`
    -> netstack/tcp.go:186:2: field `ep` called `Abort()`

(Same nil source could also cause potential nil panic(s) at 1 other place(s): netstack/tcp.go:194:2.)

/home/murtaza/bravehub/firestack/intra/netstack/udp.go:223:80: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> udp/forwarder.go:88:10: literal `nil` returned from `CreateEndpoint()` in position 0
    -> netstack/udp.go:179:10: result 0 of `CreateEndpoint()` assigned into field `ep`
    -> netstack/udp.go:223:80: field `ep` called `State()`

(Same nil source could also cause potential nil panic(s) at 3 other place(s): netstack/udp.go:223:94, netstack/udp.go:223:107, and netstack/udp.go:244:3.)

/home/murtaza/bravehub/firestack/intra/rnet/socks5.go:470:41: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> net/net.go:215:10: literal `nil` returned from `LocalAddr()` in position 0
    -> rnet/socks5.go:470:41: result 0 of `LocalAddr()` called `String()`

/home/murtaza/bravehub/firestack/intra/rnet/socks5.go:444:31: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> net/net.go:225:10: literal `nil` returned from `RemoteAddr()` in position 0
    -> rnet/socks5.go:444:31: result 0 of `RemoteAddr()` called `String()`

/home/murtaza/bravehub/firestack/intra/x64/dns64.go:214:24: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> xdns/dnsutil.go:81:10: literal `nil` returned from `EmptyResponseFromMessage()` in position 0
    -> x64/dns64.go:214:24: result 0 of `EmptyResponseFromMessage()` accessed field `Answer`

(Same nil source could also cause potential nil panic(s) at 1 other place(s): x64/dns64.go:214:2.)

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:123:10: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> xdns/dnsutil.go:56:10: literal `nil` returned from `Request4FromResponse6()` in position 0
    -> x64/dns64.go:243:82: result 0 of `Request4FromResponse6()` passed as arg `msg` to `QName()`
    -> xdns/dnsutil.go:123:10: function parameter `msg` accessed field `Question`

/home/murtaza/bravehub/firestack/intra/xdns/dnsutil.go:123:10: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> xdns/dnsutil.go:56:10: literal `nil` returned from `Request4FromResponse6()` in position 0
    -> x64/dns64.go:232:81: result 0 of `Request4FromResponse6()` passed as arg `msg` to `QName()`
    -> xdns/dnsutil.go:123:10: function parameter `msg` accessed field `Question`

/home/murtaza/bravehub/firestack/intra/x64/nat64.go:32:16: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> x64/natpt.go:141:9: literal `nil` returned from `matchNat64()` in position 0
    -> x64/natpt.go:87:18: result 0 of `matchNat64()` passed as arg `prefix64` to `xAddr()`
    -> x64/nat64.go:27:16: function parameter `prefix64` passed as arg `prefix64` to `ip6to4()`
    -> x64/nat64.go:32:16: function parameter `prefix64` accessed field `Mask`

/home/murtaza/bravehub/firestack/intra/bootstrap.go:147:66: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> intra/bootstrap.go:147:66: result 0 of `newDefaultTransport()` lacking guarding; called `GetAddr()`

/home/murtaza/bravehub/firestack/intra/bootstrap.go:147:66: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> intra/bootstrap.go:147:66: result 0 of `newDefaultDohTransport()` lacking guarding; called `GetAddr()`

/home/murtaza/bravehub/firestack/intra/bootstrap.go:147:66: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> intra/bootstrap.go:147:66: unassigned variable `tr` called `GetAddr()`

/home/murtaza/bravehub/firestack/intra/dns.go:109:32: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> strings/strings.go:242:10: literal `nil` returned from `genSplit()` in position 0
    -> strings/strings.go:312:45: result 0 of `genSplit()` returned from `Split()` in position 0
    -> intra/dns.go:109:32: result 0 of `Split()` sliced into

/home/murtaza/bravehub/firestack/intra/tcp.go:381:9: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> net/ip.go:498:9: literal `nil` returned from `ParseIP()` in position 0
    -> intra/tcp.go:381:9: result 0 of `ParseIP()` called `IsUnspecified()`

(Same nil source could also cause potential nil panic(s) at 1 other place(s): intra/tcp.go:398:8.)

/home/murtaza/bravehub/firestack/intra/udp.go:178:14: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> intra/udp.go:178:14: unassigned variable `err` called `Error()`

/home/murtaza/bravehub/firestack/intra/dialers/retrier_test.go:84:11: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> dialers/retrier_test.go:154:22: result 0 of `AcceptTCP()` lacking guarding; assigned into field `serverSide`
    -> dialers/retrier_test.go:98:28: field `serverSide` passed as arg `dest` to `send()`
    -> dialers/retrier_test.go:84:11: function parameter `dest` called `Read()`

/home/murtaza/bravehub/firestack/intra/doh/client_auth_test.go:190:39: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> pem/pem.go:118:12: literal `nil` returned from `Decode()` in position 0
    -> doh/client_auth_test.go:190:39: result 0 of `Decode()` accessed field `Bytes`

(Same nil source could also cause potential nil panic(s) at 9 other place(s): doh/client_auth_test.go:166:46, doh/client_auth_test.go:166:60, doh/client_auth_test.go:187:39, doh/client_auth_test.go:166:31, doh/client_auth_test.go:213:51, doh/client_auth_test.go:230:39, doh/client_auth_test.go:213:31, doh/client_auth_test.go:285:51, and doh/client_auth_test.go:285:31.)

/home/murtaza/bravehub/firestack/intra/doh/client_auth_test.go:230:18: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> doh/client_auth_test.go:230:18: result 0 of `GetClientCertificate()` lacking guarding; accessed field `Certificate`

(Same nil source could also cause potential nil panic(s) at 1 other place(s): doh/client_auth_test.go:227:9.)

/home/murtaza/bravehub/firestack/intra/doh/client_auth_test.go:265:9: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> doh/client_auth_test.go:265:9: result 0 of `GetClientCertificate()` lacking guarding; accessed field `Certificate`

/home/murtaza/bravehub/firestack/intra/doh/client_auth_test.go:300:9: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> doh/client_auth_test.go:300:9: result 0 of `GetClientCertificate()` lacking guarding; accessed field `Certificate`

/home/murtaza/bravehub/firestack/intra/protect/protect_test.go:90:2: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> net/iprawsock_posix.go:146:10: literal `nil` returned from `listenIP()` in position 0 when the error return in position 1 is not guaranteed to be non-nil through all paths
    -> net/dial.go:774:9: result 0 of `listenIP()` returned from `ListenPacket()` in position 0
    -> protect/protect_test.go:90:2: result 0 of `ListenPacket()` called `Close()`

(Same nil source could also cause potential nil panic(s) at 1 other place(s): protect/protect_test.go:132:2.)

/home/murtaza/bravehub/firestack/intra/protect/protect_test.go:44:2: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> net/tcpsock.go:120:10: literal `nil` returned from `SyscallConn()` in position 0 when the error return in position 1 is not guaranteed to be non-nil through all paths
    -> protect/protect_test.go:36:2: returned as result 0 from interface method `hasSyscallConn.SyscallConn()` (implemented by `TCPConn.SyscallConn()`)
    -> protect/protect_test.go:44:2: result 0 of `SyscallConn()` called `Control()`

/home/murtaza/bravehub/firestack/intra/protect/protect_test.go:44:2: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> net/udpsock.go:130:10: literal `nil` returned from `SyscallConn()` in position 0 when the error return in position 1 is not guaranteed to be non-nil through all paths
    -> protect/protect_test.go:36:2: returned as result 0 from interface method `hasSyscallConn.SyscallConn()` (implemented by `UDPConn.SyscallConn()`)
    -> protect/protect_test.go:44:2: result 0 of `SyscallConn()` called `Control()`

/home/murtaza/bravehub/firestack/intra/protect/ipmap/ipmap_test.go:71:5: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
    -> ipmap/ipmap.go:213:10: literal `nil` returned from `GetAll()` in position 0
    -> ipmap/ipmap_test.go:71:5: result 0 of `GetAll()` sliced into

(Same nil source could also cause potential nil panic(s) at 7 other place(s): ipmap/ipmap_test.go:99:5, ipmap/ipmap_test.go:117:15, ipmap/ipmap_test.go:113:5, ipmap/ipmap_test.go:112:12, ipmap/ipmap_test.go:152:5, ipmap/ipmap_test.go:145:33, and ipmap/ipmap_test.go:142:12.)
ignoramous commented 1 year ago

https://github.com/celzero/firestack/commit/347089b6be3bd70d5f74f3b70ed89f1574b70a5a except (_test) files.