search

celzero / firestack

Userspace wireguard and network monitor
https://rethinkdns.com/app
Mozilla Public License 2.0
87 stars 15 forks source link

lint: 7 May 2024 #50

Closed ignoramous closed 4 months ago

ignoramous commented 4 months ago

run: https://archive.is/njxug

 Running [/home/runner/golangci-lint-1.58.0-linux-amd64/golangci-lint run --out-format=github-actions --config=.golangci.yml --issues-exit-code=0] in [] ...
  Error: error  intra/backend/ipn_pipkeygen.go:82:16:   Error return value of `json.Unmarshal` is not checked (errcheck)
  Error: error  intra/common.go:257:11: Error return value of `x.Close` is not checked (errcheck)
  Error: error  intra/common.go:267:10: Error return value of `c.Close` is not checked (errcheck)
  Error: error  intra/common.go:273:15: Error return value of `x.CloseRead` is not checked (errcheck)
  Error: error  intra/common.go:275:16: Error return value of `x.CloseWrite` is not checked (errcheck)
  Error: error  intra/common.go:277:11: Error return value of `x.Close` is not checked (errcheck)
  Error: error  intra/common.go:280:10: Error return value of `x.Close` is not checked (errcheck)
  Error: error  intra/common.go:282:10: Error return value of `x.Close` is not checked (errcheck)
  Error: error  intra/core/connmap.go:115:14:   Error return value of `c.Close` is not checked (errcheck)
  Error: error  intra/core/connmap.go:163:15:   Error return value of `c.Close` is not checked (errcheck)
  Error: error  intra/core/connmap.go:227:15:   Error return value of `c.Close` is not checked (errcheck)
  Error: error  intra/dialers/ndial.go:155:10:  Error return value of `c.Close` is not checked (errcheck)
  Error: error  intra/dns53/goos.go:75:17:  func `(*goosr).dial` is unused (unused)
  Error: error  intra/dns53/mdns.go:37:2:   var `errUnexpectedProxy` is unused (unused)
  Error: error  intra/dns53/mdns.go:108:15: Error return value of `c.Close` is not checked (errcheck)
  Error: error  intra/dns53/mdns.go:308:10: Error return value is not checked (errcheck)
  Error: error  intra/dns53/mdns.go:309:10: Error return value is not checked (errcheck)
  Error: error  intra/dns53/mdns.go:310:10: Error return value is not checked (errcheck)
  Error: error  intra/dns53/mdns.go:311:10: Error return value is not checked (errcheck)
  Error: error  intra/dns53/mdns.go:457:15: Error return value is not checked (errcheck)
  Error: error  intra/dns53/mdns.go:464:15: Error return value is not checked (errcheck)
  Error: error  intra/dns53/mdns.go:490:14: Error return value is not checked (errcheck)
  Error: error  intra/ipn/wg/wgconn2.go:273:15: Error return value of `v4conn.Close` is not checked (errcheck)
  Error: error  intra/ipn/wg/wgconn2.go:684:6:  func `coalesceMessages2` is unused (unused)
  Error: error  intra/ipn/wgnet.go:43:2:    var `errInvalidDNSResponse` is unused (unused)
  Error: error  intra/ipn/wgproxy.go:373:6: func `bindWgSockets` is unused (unused)
  Error: error  intra/log/logger.go:165:12: Error return value of `l.o.Output` is not checked (errcheck)
  Error: error  intra/log/logger.go:173:12: Error return value of `l.e.Output` is not checked (errcheck)
  Error: error  intra/netstack/dispatchers.go:91:13:    Error return value of `buf.Append` is not checked (errcheck)
  Error: error  intra/netstack/icmp.go:79:14:   Error return value of `din8.Append` is not checked (errcheck)
  Error: error  intra/netstack/icmp.go:84:14:   Error return value of `din8.Append` is not checked (errcheck)
  Error: error  intra/netstack/icmp.go:90:13:   Error return value of `din.Append` is not checked (errcheck)
  Error: error  intra/netstack/icmp.go:123:15:  Error return value of `res.Append` is not checked (errcheck)
  Error: error  intra/netstack/icmp.go:125:15:  Error return value of `res.Append` is not checked (errcheck)
  Error: error  intra/netstack/icmp.go:128:14:  Error return value of `res.Append` is not checked (errcheck)
  Error: error  intra/netstack/icmp.go:192:14:  Error return value of `din8.Append` is not checked (errcheck)
  Error: error  intra/netstack/icmp.go:197:14:  Error return value of `din8.Append` is not checked (errcheck)
  Error: error  intra/netstack/icmp.go:203:13:  Error return value of `din.Append` is not checked (errcheck)
  Error: error  intra/netstack/icmp.go:230:15:  Error return value of `res.Append` is not checked (errcheck)
  Error: error  intra/netstack/icmp.go:232:15:  Error return value of `res.Append` is not checked (errcheck)
  Error: error  intra/netstack/icmp.go:235:14:  Error return value of `res.Append` is not checked (errcheck)
  Error: error  intra/netstack/icmpv2.go:254:21:    Error return value of `tr.sendUnreachable` is not checked (errcheck)
  Error: error  intra/netstack/icmpv2.go:256:22:    Error return value of `tr.sendEchoResponse` is not checked (errcheck)
  Error: error  intra/netstack/icmpv2.go:477:12:    Error return value of `din.Append` is not checked (errcheck)
  Error: error  intra/netstack/netstack.go:43:17:   Error return value of `syscall.Close` is not checked (errcheck)
  Error: error  intra/netstack/tcp.go:90:10:    Error return value of `g.Close` is not checked (errcheck)
  Error: error  intra/netstack/tcp.go:92:11:    Error return value of `g.synack` is not checked (errcheck)
  Error: error  intra/netstack/tcp.go:214:10:   Error return value of `c.Close` is not checked (errcheck)
  Error: error  intra/netstack/tcp.go:225:16:   Error return value of `c.SetDeadline` is not checked (errcheck)
  Error: error  intra/netstack/udp.go:106:12:   Error return value of `g.Connect` is not checked (errcheck)
  Error: error  intra/netstack/udp.go:216:16:   Error return value of `c.SetDeadline` is not checked (errcheck)
  Error: error  intra/netstat/procfs.go:235:16: Error return value of `fd.Close` is not checked (errcheck)
  Error: error  intra/protect/xdial.go:133:10:  Error return value of `c.Close` is not checked (errcheck)
  Error: error  intra/rnet/http.go:187:3:   ineffectual assignment to addr (ineffassign)
  Error: error  intra/rnet/http.go:191:17:  SA1019: h.Tr.Dial has been deprecated since Go 1.7: Use DialContext instead, which allows the transport to cancel dials as soon as they are no longer needed. If both are set, DialContext takes priority.  (staticcheck)
  Error: error  intra/rnet/http.go:197:14:  Error return value of `client.Write` is not checked (errcheck)
  Error: error  intra/rnet/http.go:213:16:  Error return value of `client.Close` is not checked (errcheck)
  Error: error  intra/rnet/http.go:214:16:  Error return value of `target.Close` is not checked (errcheck)
  Error: error  intra/rnet/http.go:256:3:   SA1019: h.ProxyHttpServer.Tr.Dial has been deprecated since Go 1.7: Use DialContext instead, which allows the transport to cancel dials as soon as they are no longer needed. If both are set, DialContext takes priority.  (staticcheck)
  Error: error  intra/rnet/http.go:259:3:   SA1019: h.ProxyHttpServer.Tr.Dial has been deprecated since Go 1.7: Use DialContext instead, which allows the transport to cancel dials as soon as they are no longer needed. If both are set, DialContext takes priority.  (staticcheck)
  Error: error  intra/rnet/listener.go:46:25:   func `(*ServerSummary).str` is unused (unused)
  Error: error  intra/rnet/servers.go:130:13:   Error return value of `s.Bridge` is not checked (errcheck)
  Error: error  intra/rnet/servers.go:158:14:   Error return value of `svc.Stop` is not checked (errcheck)
  Error: error  intra/rnet/servers.go:180:14:   Error return value of `svc.Stop` is not checked (errcheck)
  Error: error  intra/rnet/socks5.go:284:21:    Error return value of `egress.Close` is not checked (errcheck)
  Error: error  intra/rnet/socks5.go:314:10:    Error return value of `io.Copy` is not checked (errcheck)
  Error: error  intra/rnet/socks5.go:396:26:    Error return value of `egress.RemoteConn.Close` is not checked (errcheck)
  Error: error  intra/rnet/socks5.go:408:23:    Error return value of `ue.RemoteConn.Close` is not checked (errcheck)
  Error: error  intra/tcp.go:160:15:    Error return value of `gconn.Close` is not checked (errcheck)
  Error: error  intra/tcp.go:170:16:    Error return value of `gconn.Connect` is not checked (errcheck)
  Error: error  intra/tcp.go:176:16:    Error return value of `gconn.Connect` is not checked (errcheck)
  Error: error  intra/tcp.go:203:16:    Error return value of `gconn.Connect` is not checked (errcheck)
  Error: error  intra/udp.go:82:24: Error return value of `rw.UDPConn.SetDeadline` is not checked (errcheck)
  Error: error  intra/udp.go:87:24: Error return value of `rw.UDPConn.SetDeadline` is not checked (errcheck)
  Error: error  intra/udp.go:167:16:    Error return value of `gconn.Connect` is not checked (errcheck)
  Error: error  intra/udpmux.go:150:11: Error return value of `c.Close` is not checked (errcheck)
  Error: error  intra/udpmux.go:162:14: Error return value of `x.stop` is not checked (errcheck)
  Error: error  intra/udpmux.go:211:14: Error return value of `conn.Close` is not checked (errcheck)
  Error: error  intra/udpmux.go:237:23: Error return value of `x.mxconn.SetDeadline` is not checked (errcheck)
  Error: error  intra/udpmux.go:243:23: Error return value of `x.mxconn.SetDeadline` is not checked (errcheck)
  Error: error  intra/x64/dns64.go:41:5:    var `rfc6052WKP` is unused (unused)
  Error: error  intra/x64/dns64.go:42:5:    var `rfc8215WKP` is unused (unused)
  Error: error  intra/xdns/common.go:56:2:  var `fakedomain` is unused (unused)
  Error: error  tunnel/tunnel.go:82:2:  var `errStackMissing` is unused (unused)
  Error: error  tunnel/tunnel.go:98:10: Error return value of `w.Write` is not checked (errcheck)
  Error: error  tunnel/tunnel.go:246:11:    Error return value of `t.ep.Swap` is not checked (errcheck)
  136 issues:
  * errcheck: 108
  * ineffassign: 2
  * staticcheck: 5
  * unused: 21

  level=warning msg="[config_reader] The configuration option `run.show-stats` is deprecated, please use `output.show-stats`"
  level=warning msg="The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive."
  level=error msg="[linters_context] golint: This linter is fully inactivated: it will not produce any reports."
ignoramous commented 4 months ago

use revive: https://github.com/golang/go/issues/38968 / https://github.com/open-telemetry/opentelemetry-go/pull/1946

ignoramous commented 4 months ago

resolved all.