celzero / rethink-app

DNS over HTTPS / DNS over Tor / DNSCrypt client, WireGuard proxifier, firewall, and connection tracker for Android.
https://rethinkfirewall.com/
Apache License 2.0
3.01k stars 154 forks source link

Dismissable service notification and i18n #1119

Open didi8517 opened 1 year ago

didi8517 commented 1 year ago

Hello there, thanks for this super app and the great updates. I have two issues with the notification, one since the last update (at least): 1) in other issues I read that others are annoyed about the "persistent" notification. My problem is the opposite, it's not persistent/permanent, I can just swipe it away, and it happens often enough, just by bad luck. Ok, it's not a biggy to open the app, settings, and change it to some other setting and back to the original for it to reappear as I need it, but still... I'd prefer it to be permanent. Now I don't know if it's my phone (LG Velvet 5G, Android 13) that does that, or if it's something that was changed. If the latter is true, I'd like to have an option to set the notification to be permanent, please...

2) With the last update the app was set automatically to my local language (German), which I switched to US English. Later I realized that the notification text remained in German. I had to change the notification setting to something else (and back) for it to also become English. I tried changing it to German, and it was automatically Germanized, but when changing back again to US English, only the notification remained in German. I haven't done any further tries, but it would seem that some parts are missing in switching languages.

Edit: I just noticed that after having changed the app language back to US English, now after some time, the notification is in German again. I have no idea at what point or why this happened. The app itself is all in English.

Edit: I forgot to mention I use the 2nd setting, two buttons to switch the firewall on/off. I made a few trials and haven't found anything very consistent yet, but the change in language happens when I change to DNS only and the notification has to change, then it will revert to system language (German in my case). This will not happen if I've just changed the notification settings around again so it will be in English again, but I can't tell how much time has to go by, or if some specific event or so has to occur, before the language change happens again... Once I tried it after like 2 minutes and it happened. Then I reverted to English, and since then every couple of minutes I hit the buttons and nothing happens (i.e. it remains in English). That's what I meant with no recognisable consistency so far.

hussainmohd-a commented 1 year ago

Hi @didi8517, thank you for reporting the issue. We will look into it.