celzero / rethink-app

DNS over HTTPS / DNS over Tor / DNSCrypt client, WireGuard proxifier, firewall, and connection tracker for Android.
https://rethinkfirewall.com/
Apache License 2.0
3k stars 153 forks source link

Renaming WireGuard configurations #1524

Open soshial opened 5 months ago

soshial commented 5 months ago

Using RethinkDNS to switch between WireGuard servers is quite inconvenient compared to the official WireGuard client, since there are no names. (Using *.conf filenames is the easiest solution, I think)

Compare:

ignoramous commented 5 months ago

If you re-import the WireGuard configuration, you'd see Rethink uses names from the conf files now (started doing this in v055k, I think).

Today, there's no way to rename these configurations. May be we should implement that.

soshial commented 5 months ago

Cool! If it already uses filenames, then it's great. Not sure it's worth the effort renaming old ones (maybe you may show an info on that screen that it's possible to reimport those)

soshial commented 5 months ago

I am regularly checking for changelogs... It would be nice to those not only here, but also in fastlane folder for F-Droid.

ignoramous commented 5 months ago

I am regularly checking for changelogs...

We don't add every single change in changelogs, only the major ones. Best to look at the bugs we comment on or close after a release is done (usually, we close bugs after Play Store release).

ignoramous commented 5 months ago

Not sure it's worth the effort renaming old ones (maybe you may show an info that it's possible to reimport those)

It didn't even occur to us folks would import more than 3 WireGuard profiles :laughing:

It would be nice to those not only here

I am not sure F-Droid picksup changelogs like before. I think we stopped doing those for a reason... May be we are mistaken.

soshial commented 5 months ago

It didn't even occur to us folks would import more than 3 WireGuard profiles 😆

Well, when I download a configuration list from my VPN provider, I get all servers. And WireGuard was so unstable (either mobile app or VPN provider server client), that my connection got dropped once per day or maybe even more often, so that I had to switch to other servers regularly. It was terrible 😆😆

soshial commented 5 months ago

I have just realized that I can't delete WireGuard configs neither 1-by-1, nor by selecting all of them.

Also, they got pretty crazy here — configs started to select and deselect on their own (without me clicking anything). Also, it writes status "ACTIVE", while RethinkDNS in not enabled and is paused.

https://github.com/celzero/rethink-app/assets/100644/8f6d396e-b82b-4bfc-9e7b-3b6d86dc6d35

soshial commented 5 months ago

Also, a couple of enhancements:

Thank you!

hussainmohd-a commented 5 months ago

Hi @soshial, can you let me know the version of Rethink you are using? You can find it at the bottom of the About screen.

soshial commented 5 months ago

I'm on F-Droid, so I'm a bit late from the latest update. I have this bug on 0.5.5m — it's my current version.

hussainmohd-a commented 5 months ago

@soshial, This issue seems concerning; Simple mode should not allow more than one WireGuard instance.

ignoramous commented 5 months ago

have just realized that I can't delete WireGuard configs neither 1-by-1, nor by selecting all of them.

screenshot: image0: ![Screenshot_2024-06-11-17-48-09-31_c8cbde12d3521911922be4eee6a05664~2](https://github.com/celzero/rethink-app/assets/852289/ad596dc7-550e-44ca-97ff-ffe7f7b784aa)
soshial commented 5 months ago

Thank you, probably 2 "delete" icons confused me. I was able to delete them

BTW, it's not possible to open WireGuard configuration, when RethinkDNS is OFF (not in active state). Now I can.

Hamed516 commented 5 months ago

Using RethinkDNS to switch between WireGuard servers is quite inconvenient compared to the official WireGuard client, since there are no names. (Using *.conf filenames is the easiest solution, I think)

Compare: