search

celzero / rethink-app

DNS over HTTPS / DNS over Tor / DNSCrypt client, WireGuard proxifier, firewall, and connection tracker for Android.
https://rethinkfirewall.com/
Apache License 2.0
2.89k stars 147 forks source link

v055n: App hangs on STOP #1629

Open JonnyTech opened 2 months ago

JonnyTech commented 2 months ago

On my Android 13 device, I start the Rethink app and leave it running. The persistent notification remains in the task bar. Later when I want to stop it, I try to click the STOP label in the notification or the stop button in the app but neither respond. The only solution is to force quit the app, then open it again, then I can click the stop button. Is this a known bug and is there a fix available?

Version v0.5.5n from F-Droid.

ignoramous commented 2 months ago

I've seen this happens at times, and it is annoying, and has multiple reasons. We continue to improve the way we stop of the VPN tunnel and the app's network engine. In v055o (the next version due in a week or so) we've put in a fixed heartbeat-like liveliness timeout (code) to forcefully stop the network engine after 15s of inactivity.

JonnyTech commented 2 months ago

Thank you for your feedback.

to forcefully stop the network engine after 15s of inactivity.

I want to keep the engine alive until I decide to stop it myself. I am not a heavy user so am now worried that the next version will disconnect often.

The issue is with the GUI app interface, that is what locks up, not the engine. Is there any way to revive that, instead of force closing then restarting it?

ignoramous commented 2 months ago

I want to keep the engine alive until I decide to stop it myself. I am not a heavy user so am now worried that the next version will disconnect often.

Of course, this timeout doesn't work the way you think it does. I specifically mentioned "heartbeat" and "liveliness" for a reason (:

The issue is with the GUI app interface, that is what locks up, not the engine. Is there any way to revive that, instead of force closing then restarting it?

If it is the UI that's locked up, Android should ANR (activity not responding) crash it in 5s to 10s. If not, something else is (in our experience, it is the network engine, which is a complicated piece of code, that sometimes takes too long to... close).

JonnyTech commented 2 months ago

Great - awaiting v055o to drop in FDroid then I shall test and report back :+1: