celzero / rethink-app

DNS over HTTPS / DNS over Tor / DNSCrypt client, WireGuard proxifier, firewall, and connection tracker for Android.
https://rethinkfirewall.com/
Apache License 2.0
3.01k stars 154 forks source link

[Feature Request] Option to change (or disable) the captive portal check #1679

Open th3m opened 2 months ago

th3m commented 2 months ago

Changing the captive portal servers is a privacy benefit and no root privileges needed. There are presets from GrapheneOS, Kuketz and of course the default of Google.

I believe adding this option, goes well with the spirit of the app.

Another minor option could also be to be able to change the time server(ntp_server)

ignoramous commented 2 months ago

Rethink doesn't do captive portal checks. This is done by Android itself. I don't believe Rethink can change how captive portals are detected by Android.

ntp

shuvashish76 commented 2 months ago

I vote for this feature as well. I agree it goes in the sprit of RDNS privacy specific feature list. Reference : https://github.com/MuntashirAkon/CaptivePortalController

ignoramous commented 2 months ago

Reference : https://github.com/MuntashirAkon/CaptivePortalController

Requires a special "write settings secure" permission? Changing such settings is usually better left to the OS itself; but we'll consider adding this once we get Material You / Android TV support out of the way (~6 to 12 months).