search

celzero / rethink-app

DNS over HTTPS / DNS over Tor / DNSCrypt client, WireGuard proxifier, firewall, and connection tracker for Android.
https://rethinkfirewall.com/
Apache License 2.0
2.75k stars 137 forks source link

Google play console fixes #378

Closed hussainmohd-a closed 2 years ago

hussainmohd-a commented 2 years ago

Issue 1: Null pointer exception

java.lang.NullPointerException: 
  at com.celzero.bravedns.ui.SettingsFragment.initView (SettingsFragment.kt:173)
  at com.celzero.bravedns.ui.SettingsFragment.onViewCreated (SettingsFragment.kt:99)
  at androidx.fragment.app.Fragment.performViewCreated (Fragment.java:2987)
  at androidx.fragment.app.FragmentStateManager.createView (FragmentStateManager.java:546)
  at androidx.fragment.app.FragmentStateManager.moveToExpectedState (FragmentStateManager.java:282)
  at androidx.fragment.app.FragmentManager.executeOpsTogether (FragmentManager.java:2189)
  at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute (FragmentManager.java:2100)
  at androidx.fragment.app.FragmentManager.execPendingActions (FragmentManager.java:2002)
  at androidx.fragment.app.FragmentManager$5.run (FragmentManager.java:524)
  at android.os.Handler.handleCallback (Handler.java:794)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loop (Looper.java:176)
  at android.app.ActivityThread.main (ActivityThread.java:6651)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:547)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:824)

code

Issue 2: Array Index out of bounds

java.lang.ArrayIndexOutOfBoundsException: 
  at com.celzero.bravedns.service.IPTracker.insertToDB (IPTracker.kt:117)
  at com.celzero.bravedns.service.IPTracker.access$insertToDB (IPTracker.kt:40)
  at com.celzero.bravedns.service.IPTracker$recordTransaction$1.invokeSuspend (IPTracker.kt:62)
  at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (BaseContinuationImpl.kt:33)
  at kotlinx.coroutines.DispatchedTask.run (DispatchedTask.kt:106)
  at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely (CoroutineScheduler.kt:571)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask (CoroutineScheduler.kt:750)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker (CoroutineScheduler.kt:678)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run (CoroutineScheduler.kt:665)

code

hussainmohd-a commented 2 years ago

Issue1 fix: Null pointer caused by assertion in the code, sock5Proxy!!.proxyIP which is now removed

Issue2 fix: Now the check for the Array<out String> is for both null and isNotEmpty().