search

celzero / rethink-app

DNS over HTTPS / DNS over Tor / DNSCrypt client, WireGuard proxifier, firewall, and connection tracker for Android.
https://rethinkfirewall.com/
Apache License 2.0
2.93k stars 148 forks source link

Adaptive Icon #511

Closed ghost closed 1 year ago

ghost commented 2 years ago

Could you make the app icon adaptive so it follows the shape of other app icons?

ignoramous commented 2 years ago

Not sure what an 'adaptive icon' means. You mean, the current icon isn't in proper shape? It is rectangular today.

ghost commented 2 years ago

The icon is in a bubble when icon shapes are changed.

ignoramous commented 2 years ago

Can you please share a screenshot? I use Lawnchair 2 with squircle-shaped icon pack. Rethink's icon doesn't look any more different than the other squircle ones.

ghost commented 2 years ago

Screenshot_20220908-165700_Trebuchet The icon is in a bubble unlike the other icons.

ignoramous commented 2 years ago

Gotcha. Thanks for sharing the screenshot. I don't know what needs to be done, but I'll keep looking.

severtheskyline commented 2 years ago

It shouldn't be that difficult, to my knowledge, you would need a white background and the RethinkDNS logo transparent and, with the appropriate names and sizes, Android should do the rest.

ignoramous commented 2 years ago

It shouldn't be that difficult, to my knowledge, you would need a white background and the RethinkDNS logo transparent and, with the appropriate names and sizes, Android should do the rest.

Difficulty is relative isn't it? I wouldn't know how to do that (I haven't managed to)... Not sure if the lead developer on the app knows how to do so pixel-perfectly, either.

ignoramous commented 2 years ago

https://developer.android.com/develop/ui/views/launch/icon_design_adaptive

hussainmohd-a commented 1 year ago

Introduced new adaptive icons for various screen resolutions: https://github.com/hussainmohd-a/rethink-app/commit/b927908d1097aa09b14dcac0b06eee26b0fbcc0b

severtheskyline commented 1 year ago

The adaptive icon doesn't work in the latest update.

ignoramous commented 1 year ago

Not sure what has changed, since the drawables are intact... will take a look.

ignoramous commented 1 year ago

@PandoraPandorita I rollbacked to v053n and adaptive icon is working...? As in, I drag the icon around and I can see the logo within it bounce about in Lawnchair 2... What are you seeing instead?

severtheskyline commented 1 year ago

Guess should've specified lol.

Here's the icon from 053L on my phone's stock launcher:

Screenshots_2023-01-26-22-08-20

That's what's expected, now, here's on my tablet which uses Lawnchair 10 with Quickswitch and other apps as reference:

IMG_20230126_221224

(The icon shape was changed for this example)

Now, here is what 053M and 053N looks like on my phone's stock launcher:

Screenshots_2023-01-26-22-13-20

And again, here's in my tablet with the same setup and 053N version of the app with others as reference:

IMG_20230126_221245

Other details that may help are that these are the F-Droid builds, and that both of my devices run Android 10, my tablet runs a really stock-like Android and my phone runs under LG UX, just if it helps.

Also, it took a bit for the response since using this crappy LG to report issues is a torture.

ignoramous commented 1 year ago

Wow. Thanks for the screenshots. Appreciate you going through the hassle of it all.

We will take a look. From the code at least, we haven't removed those icon drawables. May be something in the build system (which we changed quite a bit with the previous update, v053m) is mucking with those. We'll check and get back.

hussainmohd-a commented 1 year ago

Fixed: #646aefa, will be part of v054b