celzero / rethink-app

DNS over HTTPS / DNS over Tor / DNSCrypt client, WireGuard proxifier, firewall, and connection tracker for Android.
https://rethinkfirewall.com/
Apache License 2.0
2.96k stars 148 forks source link

IllegalStateException: onSaveInstanceState in HomeScreenFragment.openBottomSheet #663

Closed ignoramous closed 1 year ago

ignoramous commented 1 year ago

report

Exception java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
  at androidx.fragment.app.FragmentManager.checkStateLoss (FragmentManager.java:1610)
  at androidx.fragment.app.FragmentManager.enqueueAction (FragmentManager.java:1650)
  at androidx.fragment.app.BackStackRecord.commitInternal (BackStackRecord.java:341)
  at androidx.fragment.app.BackStackRecord.commit (BackStackRecord.java:306)
  at androidx.fragment.app.DialogFragment.show (DialogFragment.java:262)
  at com.celzero.bravedns.ui.HomeScreenFragment.openBottomSheet (HomeScreenFragment.kt:654)
  at com.celzero.bravedns.ui.HomeScreenFragment.access$openBottomSheet (HomeScreenFragment.kt:80)
  at com.celzero.bravedns.ui.HomeScreenFragment$showStartDialog$1$1.invoke (HomeScreenFragment.kt:821)
  at com.celzero.bravedns.ui.HomeScreenFragment$showStartDialog$1$1.invoke (HomeScreenFragment.kt:819)
  at com.celzero.bravedns.util.Utilities$Companion$delay$1.invokeSuspend (Utilities.kt:459)
  at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (ContinuationImpl.kt:33)
  at kotlinx.coroutines.internal.DispatchedContinuation.resumeUndispatchedWith (DispatchedContinuation.java:256)
  at kotlinx.coroutines.DispatchedTaskKt.resume (DispatchedTask.kt:177)
  at kotlinx.coroutines.DispatchedTaskKt.dispatch (DispatchedTask.kt:166)
  at kotlinx.coroutines.CancellableContinuationImpl.dispatchResume (CancellableContinuationImpl.kt:397)
  at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl (CancellableContinuationImpl.kt:431)
  at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl$default (CancellableContinuationImpl.kt:420)
  at kotlinx.coroutines.CancellableContinuationImpl.resumeUndispatched (CancellableContinuationImpl.kt:518)
  at kotlinx.coroutines.android.HandlerContext$scheduleResumeAfterDelay$$inlined$Runnable$1.run (Runnable.kt:19)
  at android.os.Handler.handleCallback (Handler.java:938)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loopOnce (Looper.java:210)
  at android.os.Looper.loop (Looper.java:299)
  at android.app.ActivityThread.main (ActivityThread.java:8261)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:556)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1045)
hussainmohd-a commented 1 year ago

Similar to issue: https://github.com/celzero/rethink-app/issues/606

Applied fix as part of commit: a9b1fe45213a1dff84b0e64f35ecf2bd73d9c8de

Testing in progress.

hussainmohd-a commented 1 year ago

Some of the early fixes for this issue (numbers #601, #459, #264, and #132) appear to have also resolved the current problem. we are closing this issue as fixed. If we encounter any further problems, will reopen this issue or create a new one.