search

celzero / rethink-app

DNS over HTTPS / DNS over Tor / DNSCrypt client, WireGuard proxifier, firewall, and connection tracker for Android.
https://rethinkfirewall.com/
Apache License 2.0
2.64k stars 134 forks source link

Blocklists download/update doesn't work #952

Open RedSteel-1 opened 11 months ago

RedSteel-1 commented 11 months ago

The process of downloading/updating blockilists is constantly stuck, the "downloading" circle animation goes on for 1 hour now without any changes. On 2 different phones.

Could this be fixed?

Is there something wrong going on with the blocklist sources?

Update 30 minutes later:

Something is certainly wrong.

ignoramous commented 11 months ago

Are you from China / Turkmenistan? Some countries block rethinkdns servers, so downloads won't succeed: https://github.com/celzero/rethink-app/issues/293

If not, consider toggling Use in-app downloader (from DNS -> Configure -> Advanced) to see if the blocklist download then works?

If not, and if you know how, can you share the output from adb logcat as you attempt a new download (which fails)?

RedSteel-1 commented 11 months ago

Are you from China / Turkmenistan?

No I'm not from any of the countries where the servers could b blocked

If not, consider toggling Use in-app downloader (from DNS -> Configure -> Advanced) to see if the blocklist download then works?

Trying right now, will post the result whether it worked or not. It's running 10 minutes with "download in progress" so far

In any case, this is very strange, the download has been working before.

I have Rethink running in always-on & lockdown modes, Download Manager is not blocked in the firewall, so all should be working..

RedSteel-1 commented 11 months ago

If not, consider toggling Use in-app downloader (from DNS -> Configure -> Advanced) to see if the blocklist download then works?

Took a while, but the download was successful, thanks for the workaround.

Wondering, why it doesn't work with Download Manager? It is not blocked and has internet access

ignoramous commented 11 months ago

Wondering, why it doesn't work with Download Manager? It is not blocked and has internet access

Do you have the setting Use in-app downloader turned ON or OFF? If it is turned OFF, then Android's built-in Download Manager is what's working.

RedSteel-1 commented 11 months ago

Now I have it ON now, after your advice, and it worked.

So, wondering why it doesn't work with Download Manager while it is not blocked and has internet access, it worked before.

ignoramous commented 11 months ago

So, wondering why it doesn't work with Download Manager while it is not blocked and has internet access, it worked before.

My guesses are:

  1. Your device is on a custom ROM that has a broken Download Manager.
  2. Your device is on latest and greatest Android version we haven't yet tested Rethink on.
  3. There's a bug in the way Rethink uses the Download Manager (unlikely).
  4. Rethink downloads are blocked either by the ISP or the router or something.
RedSteel-1 commented 11 months ago

1 and 2 sound doubtfully: I have Graphene and /e/ on my phones, 4 the same, cause the result is the same on different networks in 2 different european countries..

ignoramous commented 11 months ago

Graphene and /e/ might have a subtly broken Download Manager... Very likely.

If you are technical enough, can you share adb logcat output as you attempt to download using the built-in Download Manager?

hussainmohd-a commented 10 months ago

Looks like we've run into a issue when the VPN is in lockdown mode and the 'Use in-app downloader' is turned off. Essentially, the Android download manager isn't kicking off downloads when this happens.

@A-7666, To double-check, if you start a download in lockdown mode and then try turning off the lockdown mode, the download manager will kickstart the pending download: #983

RedSteel-1 commented 10 months ago

@hussainmohd-a , oh ok. Strange, cause I don't recall it to be the case before. If I remember correctly, the blocklists on my other phone (which is now dead) were from 2022.12, maybe this is when this issue appeared in Rethink.

@ignoramous , Well I haven't noticed any issues with is other than with Rething blocklists so far. Regarding the adb log, I can't do in in the near future sadly :-/

iambeingtracked commented 10 months ago

Hey, same issue here

I have a logcat of the problem http://0.vern.cc/E4.png

ignoramous commented 10 months ago

I have a logcat of the problem http://0.vern.cc/E4.png

Thanks. Looks like Rethink on your Android does not have access to read from / write to the Downloads folder? Rethink does request this permission, may be it has been revoked or not granted?

iambeingtracked commented 10 months ago

Exactly, it does not request the permission https://files.wherelinux.xyz/all-files-permissions.jpg

ignoramous commented 10 months ago

Exactly, it does not request the permission https://files.wherelinux.xyz/all-files-permissions.jpg

You're right.

Unsure why WRITE_EXTERNAL_STORAGE permission was removed in this commit: https://github.com/celzero/rethink-app/commit/a9b1fe45213a1dff84b0e64f35ecf2bd73d9c8de

npahakis commented 1 week ago

I downloaded Rethinkdns through fdroid on my Galaxy S20 (official ROM but debloated a bit) yesterday and wanted to manage blocklists, but the initial download would not do anything. Resetting the app wouldn't work either. The workaround then was to enable in-app downloader and suddenly it worked. I dont recall having had these problems, the last time I hat to install the app in February.

What I noticed was, when I decided to stop the download that was going nothing and subsequently turned off the vpn, the download manager suddenly started downloading the files. This happens every time the blocklist download is started, aborted and the vpn stopped afterwards. But even if the download with deactivated vpn succeeded for all the files, the app couldn't work with that and started the process from scratch.

Why is vpn on even required for the blocklists to download? It seems like that was what prevented the download in the first place.