search

cemerick / austin

The ClojureScript browser-REPL rebuilt stronger, faster, easier.
510 stars 31 forks source link

fixes #21

Closed danielsz closed 11 years ago

danielsz commented 11 years ago

Two fixes

1, Documentation needs to specify that calling order is important, otherwise people integrating austin in their projects may inadvertently hang their cljs repl. The compiled ClojureScript namespace requiring the browser-REPL has to be loaded before this snippet:

[:script (cemerick.austin.repls/browser-connected-repl-js)]

2, bumped austin version for demo

cemerick commented 11 years ago

To clarify: was the problem you were having due to the (browser-connected-repl-js) value being injected into the page prior to the <script> reference to your app's compiled JavaScript?

danielsz commented 11 years ago

Yes, exactly.

It's just a common pitfall when integrating austin in existing projects, and something that the documentation can help mitigate.

cemerick commented 11 years ago

OK, sure. I do find the proposed wording confusing though, which is why I asked the clarifying question.

Could you update to something like "Be sure to load the code returned by the (browser-connected-repl-js) call (or your own (clojure.browser.repl/connect …) call) as the last JavaScript loaded by your app's page."?

danielsz commented 11 years ago

Agreed.

cemerick commented 11 years ago

Thanks!