Use with-open in handle-request to close the reader.

cemerick / austin

The ClojureScript browser-REPL rebuilt stronger, faster, easier.

510 stars 31 forks source link

Use with-open in handle-request to close the reader. #46

Closed r0man closed 10 years ago

r0man commented 10 years ago

Hi Chas,

while tracking down my "too many open files" issue I also found one issue in austin. Would you like to merge this?

Thanks, Roman.

cemerick commented 10 years ago

I believe slurp is safe, as it does its own with-open dance…?

r0man commented 10 years ago

yep, you are right. looks like i was a little bit to paranoid ...

On Wed, Jan 29, 2014 at 1:15 PM, Chas Emerick notifications@github.comwrote:

I believe slurphttps://github.com/clojure/clojure/blob/master/src/clj/clojure/core.clj#L6303is safe, as it does its own with-open dance...?

Reply to this email directly or view it on GitHubhttps://github.com/cemerick/austin/pull/46#issuecomment-33579359 .

cemerick commented 10 years ago

OK, closing.