search

cemerick / austin

The ClojureScript browser-REPL rebuilt stronger, faster, easier.
510 stars 31 forks source link

Austin not compatible with cljs-2356 #70

Closed dmarjenburgh closed 9 years ago

dmarjenburgh commented 9 years ago

Hi Chas,

In the following Clojurescript commit, the macro cljs.compiler/with-core-cljs macro was changed to a function of [opts body] where body is a no-arg fn. https://github.com/clojure/clojurescript/commit/80ea15ed80f90669379dc08d40edd399fd415ae7#diff-57a98267a70154befa3b47a95ec43ec8R861

This causes https://github.com/cemerick/austin/blob/master/src/clj/cemerick/austin.clj#L321 to fail with an ArityException.

I'm not sure what that line does (there's no body at all), but changing the line to (comp/with-core-cljs nil (fn []) seemed to solve the problem.

Do you want me to submit a patch for this?

mrcslws commented 9 years ago

Pasting the full error message, just in case it helps people find this issue via search engine :)

ArityException Wrong number of args (0) passed to: compiler/with-core-cljs  clojure.lang.AFn.throwArity (AFn.java:429)
dmarjenburgh commented 9 years ago

I went ahead and created a pull request (https://github.com/cemerick/austin/pull/71) with a minimal set of changes to be made in order to support cljs-2356 for when it's ready.

josf commented 9 years ago

I had this problem this morning with cljs-2356 but it has disappeared with cljs-2371.

dmarjenburgh commented 9 years ago

Great. https://github.com/clojure/clojurescript/commit/9df358dbbd617a95ae3a842db46ae62447cb3b66

I'll just close this issue.