cemerick / clojurescript.test

A maximal port of `clojure.test` to ClojureScript. DEPRECATED
165 stars 32 forks source link

Slimerjs does not work with existing tests #96

Closed jmckitrick closed 9 years ago

jmckitrick commented 9 years ago

Running the test suite under 0.3.3 with slimerjs dropped into as a straight replacement for phantomjs, I get this failure:

Subprocess failed

Here is my cljsbuild test configuration:

:test-commands {"client-test" [;;"phantomjs" :runner "slimerjs" :runner "resources/es5-shim.js" "resources/es5-sham.js" "resources/console-polyfill.js" "resources/public/js/client-test.js"]}

jeluard commented 9 years ago

Are you using OSX? If yes this is an known slimerjs issue. Installing slimerjs via brew fixed the issue for me.

cemerick commented 9 years ago

Thanks for picking this up, @jeluard. I didn't know where to start with this one. I don't have easy access to an OS X machine, FWIW.

jmckitrick commented 9 years ago

@jeluard I've make progress after installing via brew. But now I've run into this:

Compiling ClojureScript. Compiling ClojureScript. Running ClojureScript test: client-test Error during the script execution [Exception] Error: Permission denied to access property "CoffeeScript" filename:coffee-scripts.js line:8

Stack trace: 0:@coffee-scripts.js:8:177012 @coffee-scripts.js:8:2

jeluard commented 9 years ago

No idea about that one but after some googling it looks related to iframes. It might be a limitation of current implementation of clojurescript.test.

cemerick commented 9 years ago

Such "security" issues motivated 64459d4efa6d83, which I had hoped resolved the problem. (That will likely get reverted in order to fix #88, but probably won't happen until I [or someone?] does the work to support :none.)

@j-mckitrick Where is this coffee-scripts.js coming from? It should be getting pulled into the single generated test file.

jmckitrick commented 9 years ago

I have no idea where coffee-scripts.js is coming from. It only appeared when I used slimerjs as a runner.

On Tue, Apr 14, 2015 at 10:24 AM Chas Emerick notifications@github.com wrote:

Such "security" issues motivated 64459d4 https://github.com/cemerick/clojurescript.test/commit/64459d4efa6d83a67b7ccbafa0bdf03e5df4a965, which I had hoped resolved the problem. (That will likely get reverted in order to fix #88 https://github.com/cemerick/clojurescript.test/issues/88, but probably won't happen until I [or someone?] does the work to support :none.)

@j-mckitrick https://github.com/j-mckitrick Where is this coffee-scripts.js coming from? It should be getting pulled into the single generated test file.

Reply to this email directly or view it on GitHub https://github.com/cemerick/clojurescript.test/issues/96#issuecomment-92871846 .

cemerick commented 9 years ago

Maybe it's coming from a ClojureScript / CLJSJS dependency?

jmckitrick commented 9 years ago

Hmm, not sure. The only CLJSJS I have is React. No coffeescript anywhere.

On Tue, Apr 14, 2015 at 11:37 AM Chas Emerick notifications@github.com wrote:

Maybe it's coming from a ClojureScript / CLJSJS dependency?

Reply to this email directly or view it on GitHub https://github.com/cemerick/clojurescript.test/issues/96#issuecomment-92914962 .

vikeri commented 9 years ago

I had the same issue and it was related to a bug in SlimerJs not playing well with Firefox 37. I downgraded to 36 and it worked.

m-dierker commented 9 years ago

@vikeri Thanks for this^. Helped me. :)

cemerick commented 9 years ago

Sorry for the troubles, but I've deprecated this project. Please see the notice at the top of the repo's README. This is a good thing, fundamentally. :-)