cemgunay / coleaseum-webapp

COLEASEUM
https://coleaseum-webapp.vercel.app
1 stars 0 forks source link

Added Host Sublets page #22

Closed nathanclairmonte closed 10 months ago

nathanclairmonte commented 11 months ago

closes #17

Did the following things in this PR:

Host Sublets Page

Host Listing Page

API Routes

Components

Miscellaneous

nathanclairmonte commented 11 months ago

These are great suggestions!! Love the idea of attaching the requests on the server side that's brilliant

Here are the changes I made from these suggestions:

Some other thoughts from ur comments:

cemgunay commented 10 months ago

Sorry I took forever to look at your updates homie, I am finally able to use a keyboard again lmao.

The changes are great, and yeah sorry when i said requestee I meant subTenant so you assumed correct lmao.

For it going from 1 active request to no active bids its because the listingId in Request model is a string and therefore when we are doing the aggregate in the api it cant lookup a string to an ObjectId so i changed the listingId in Requests model to be ObjectId instead of string. Hopefully this doesnt mess up anything when a new request is created but we will see when we start working on that.

For the confirmed tabs prices, you're right it should never reach the else statement since every confirmed booking should have a price. This might be because of some old testing stuff where I bugged around with things even after listings were booked but we will sort all this out like you said after we sort the request/book logic so we can just leave it for now.