cemolcay / MusicTheory

Universal music theory library for iOS, iPadOS, macOS, tvOS and watchOS in Swift
MIT License
442 stars 50 forks source link

Three pitch minor chords with sharp 5 incorrect accidental #48

Closed galchm closed 1 year ago

galchm commented 2 years ago

Title should have said "Three pitch chords whose scale starts on a black key and includes a sharp 5th pitch have incorrect accidental"

Passing in the string "E♭♯5" to Key does not return the correct accidental.

galchm commented 1 year ago

Did you close this because you corrected it or because you could not reproduce it? What version of MusicTheory incorporates the fix?

Marty

On Nov 25, 2022, at 7:23 AM, Cem Olcay @.***> wrote:



Closed #48https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcemolcay%2FMusicTheory%2Fissues%2F48&data=05%7C01%7C%7C78f7897ed8794e6c21f708dacef0a9ad%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638049830272104121%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4ZBax5EcCqwrR9ey2P9QV%2F1TUUH8%2BBNaZSNY85RjzNI%3D&reserved=0 as completed.

— Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcemolcay%2FMusicTheory%2Fissues%2F48%23event-7893571156&data=05%7C01%7C%7C78f7897ed8794e6c21f708dacef0a9ad%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638049830272104121%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ZTlkrmLNvdrOlouOZtl4wItHv0ENu1G%2BGuFEjTNQ82g%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAWVYOQ6QEBWOZYTEH6NFFEDWKDDXDANCNFSM5LDK3E2A&data=05%7C01%7C%7C78f7897ed8794e6c21f708dacef0a9ad%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638049830272104121%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=DM44yg6l7oNCDv7EUu5pgVbaapjF%2FRg8PQoq1eldkG8%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>