search

cemu-project / Cemu

Cemu - Wii U emulator
https://cemu.info
Mozilla Public License 2.0
6.8k stars 527 forks source link

Deleting some spaces #1088

Closed ghost closed 6 months ago

ghost commented 6 months ago

I inspected much of the CEMU source code and removed spaces that seemed unnecessary to me.

Exzap commented 6 months ago

Hey, I appreciate that you are trying to contribute. But when it comes to pure clean-up commits their value has to be weighted against the conflicts they can cause. In this case, merging would cause a conflict for #641 since some of the files that you cleaned up have been moved&reworked by it. Conflicts are only a minor annoyance, but empty lines are even less significant so with this in mind it's just not worth the hassle and I will unfortunately have to close this PR.

Additionally, as @capitalistspz already pointed out, you accidentally undid changes from an earlier commit. Mistakes can happen, but when you plan on submitting a PR you should review it first. Github shows you a preview of all the changes while creating the PR, make use of this to spot any potential mistakes or unwanted changes and fix those before submitting the PR.