Vulkan: several fixes and refactors

cemu-project / Cemu

Cemu - Wii U emulator

https://cemu.info

Mozilla Public License 2.0

7.21k stars 586 forks source link

Vulkan: several fixes and refactors #1132

Closed goeiecool9999 closed 6 months ago

goeiecool9999 commented 6 months ago

make surfaces entirely managed by SwapchainInfoVK (and actually destroy the surfaces in destructor)
destroy temporary surface for device enumeration
simplify SwapchainInfoVk constructor
change drawbackbuffer render pass load operation to OP_LOAD, so that when the swapchain image was cleared the black background is kept (formally, it always was in practice)
fix structure type enum
move queue family code back into VulkanRenderer

amayra commented 6 months ago

can we have "VK_KHR_synchronization2" as option in settings

Exzap commented 6 months ago

can we have "VK_KHR_synchronization2" as option in settings

There isn't really a point to it being available as an option. The reason we want to use it is that it's just a tiny bit faster. But if we make the code path dynamic that introduces branching overhead and it would offset the benefit while also making the code a lot more complicated.

Exzap commented 6 months ago

On a side note including anything from gui in non-GUI code is something we really want to move away from. The Vulkan renderer shouldn't be tightly coupled to our wxWidgets/UI code and in the long term we should find a more abstract interface to handle the canvas. I know you just moved things around and didn't introduce this, just a FYI