cemu-project / cemu_graphic_packs

Community Graphic Packs for Cemu
https://cemu-project.github.io/cemu_graphic_packs/
Creative Commons Zero v1.0 Universal
1.31k stars 584 forks source link

cemu_graphic_packs repository = better place to release my mods ? #403

Open dragbe opened 4 years ago

dragbe commented 4 years ago

Material Limiter: https://gamebanana.com/gamefiles/10423 Snowquill and Desert Voe boots: https://gamebanana.com/gamefiles/10293 Weather Forecast: https://gamebanana.com/gamefiles/9291 Possible to store these mods (and my other future botw mods) in the cemu_graphic_packs repository ?

ActualMandM commented 4 years ago

The first two should be fine to add to the repo. The third one, judging from the withheld, would have to stay on GameBanana as it modifies game files (You can still link to it here).

dragbe commented 4 years ago

Repository for my cemu graphic packs collection: https://github.com/dragbe/cemu_graphic_packs/ GameBanana topic: https://gamebanana.com/scripts/10509

ActualMandM commented 4 years ago

If they are just code patches, you are free to make a pull request to the repo

Crementif commented 3 years ago

I've been following some of your work, and I think it'd definitely be cool to add some of it now. Especially since graphic packs and Cemu's patches format, since you opened up this issue, have gotten much better to create more complicated graphic packs with.

I'm currently including some of your Weather Forecast mod ideas/changes into the current Weather pack that we've got, and updating them to use the V5 graphic pack features (I assume you don't mind this, and you'll be given credit in the description of the graphic pack ofc).

And maybe we could do some of the other patches too under perhaps a "Gameplay Changes" category. Definitely cool though.

dragbe commented 3 years ago
dragbe commented 3 years ago

For the new BOTW weather graphic pack, use 'slwi r26, r26, 2' rather than 'mulli r26, r26, 0x04'

Crementif commented 3 years ago

Well, I'd prefer to keep it more readable, and mulli is better for that. Any reason besides shifting being faster to use that?

dragbe commented 3 years ago

In practice, bit shifting for multiplications and divisions by a power of 2