search

cemu-project / cemu_graphic_packs

Community Graphic Packs for Cemu
https://cemu-project.github.io/cemu_graphic_packs/
Creative Commons Zero v1.0 Universal
1.3k stars 585 forks source link

Fix Mario kart 8 lines bug #610

Closed goeiecool9999 closed 6 months ago

goeiecool9999 commented 6 months ago

Fix #573 Before: Screenshot_2024-03-10_23-15-32 After: Screenshot_2024-03-10_23-13-32 Here you can see what the textures look like in RenderDoc Screenshot_2024-03-10_23-13-12 Screenshot_2024-03-10_23-15-51

Oddly enough this only happens in OpenGL. Unless there's some rationale as to why this specific format needs to be changed that I'm unaware of it's probably best to remove this format change

Exzap commented 6 months ago

Unless there's some rationale as to why this specific format needs to be changed that I'm unaware of it's probably best to remove this format change

It's there to avoid color banding, but I don't know under which circumstances it would appear. Seems like this texture is used only for bloom or glow effects?

Anyway, I dug into this deeper on the Cemu side and it turns out there were bugs with the format overwrite feature on both OpenGL and Vulkan backends. On the latter it would mostly just be ignored and thats why there are no glitches. Commit with fixes will be pushed soon. I don't think we need to revert this PR unless we figure out what the removed rule does and if its even beneficial.