Incorrect logic in `tl-setup` answers template

cendio / ansible-role-thinlinc-server

Ansible role for the ThinLinc Server

GNU General Public License v3.0

18 stars 9 forks source link

Incorrect logic in `tl-setup` answers template #33

Closed aeneby closed 5 months ago

aeneby commented 5 months ago

This issue concerns the following line:

https://github.com/cendio/ansible-role-thinlinc-server/blob/a75bf7a8bc96efe4d3b9654de89d9505b67d6ff5/templates/thinlinc-setup.answers.j2#L9

The logic appears to be wrong; the machine should be configured as a master if it is in the thinlinc_masters group.

aeneby commented 5 months ago

I'm also unsure about the second half of the evaluation. ansible_facts['fqdn'] isn't guaranteed to be the same as what's in the inventory, so this may never match, even if it should. A better choice might be inventory_hostname, but even this seems redundant given the first half of the evaluation.