search

cenfun / monocart-coverage-reports

A code coverage tool to generate native V8 reports or Istanbul reports.
MIT License
69 stars 6 forks source link

[Bug] Dependency on minimatch v10 violates declared engines #60

Closed jakebailey closed 3 months ago

jakebailey commented 3 months ago

https://github.com/cenfun/monocart-coverage-reports/commit/8528c156f959e9fba9716a0bc5117076bc971e37 updated the minimatch dep to v10, but v10 only supports Node 20+, while monocart-coverage-reports declares Node 18+.

I think this deps should be downgraded, or this package itself needs to declare that it only supports Node 20+.

cenfun commented 3 months ago

It should be fixed in monocart-coverage-reports@2.9.3 (rollback to minimatch v9, it seems that v10 nothing changes but dropped node 18) Thanks

jakebailey commented 3 months ago

Thanks!