cengage / react-magma

https://react-magma.cengage.com
MIT License
21 stars 11 forks source link

CarbonCharts: Export carbon styles #1287

Open silvalaura opened 1 month ago

silvalaura commented 1 month ago

Currently our Carbon charts look great on Storybook, but don't have the correct styles in the docs site or when consuming it directly (ie CodeSandbox). This is because we are not exporting the carbon styles (@carbon/charts/styles.css) with our charts bundle. If we try to add that import when using our charts, then all our custom magma styles get overwritten.

Acceptance Criteria:

orion-cengage commented 1 month ago

Something happened to the titles and padding of the modal.

Image

orion-cengage commented 1 month ago

I didn't realize this would show up in the actual documentation, but we don't actually want to call this thing "CarbonChart." We should be transparent in the documentation that we use Carbon, but we want internal users to view this simply as "Charts."

Image

orion-cengage commented 1 month ago

I think it was intended for there to be a link in the opening paragraph of the docs, but it isn't rendering that way.

Image

orion-cengage commented 1 month ago

I have reviewed the updates and everything is looking good to me.