cengage / react-magma

https://react-magma.cengage.com
MIT License
21 stars 12 forks source link

A11y Fail: Pagination - Need aria-label #1387

Closed orion-cengage closed 2 weeks ago

orion-cengage commented 3 weeks ago

CENG_1959

https://react-magma.cengage.com/version/4.5.0/api/pagination/

Issue:

The pagination control uses a <nav> element but the element does not have a label to differentiate it from other navigation landmarks.

Suggestion:

Please use <nav aria-label="pagination"> to label this landmark.

silvalaura commented 3 weeks ago

We should be able to address this by adding aria-label to all our examples (it should by default trickle down to the nav tag), without explicitly adding a new prop. Or, we can decide that it's important enough that we add this as a prop that defaults to pagination but users can customize. Ideally it would be a required prop but that would be a breaking change, so maybe not at this time.

chris-cedrone-cengage commented 1 week ago

aria-label="pagination"

All set