Closed silvalaura closed 1 month ago
Latest commit: f8f0032e94913bdabed18f2765e533cbd7fd9c66
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
🚀 Deployed on https://docs-preview-1448--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1448--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://docs-preview-1448--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1448--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://docs-preview-1448--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1448--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://docs-preview-1448--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1448--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://docs-preview-1448--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1448--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://docs-preview-1448--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1448--upbeat-sinoussi-f675aa.netlify.app
I doubt we care about this, but I noticed that placeholder text doesn't get an ellipsis at narrow widths:
@chris-cedrone-cengage good point. I think this is okay because it's the same behavior as before this change was introduced.
Verified the following components are appearing as described: Input ✅ NativeSelect ✅ Select ✅ Textarea ✅ TimePicker ✅ DatePicker ✅ PasswordInput ✅ Search ✅ Combobox ✅
Tested on: https://storybook-preview-1448--upbeat-sinoussi-f675aa.netlify.app/
âž•
https://docs-preview-1448--upbeat-sinoussi-f675aa.netlify.app/
Issue: none
What I did
Removed flex-shrink. We noticed that DatePicker had a min-width of 320px because of this, and it isn't needed.
This would affect:
Checklist
How to test
Confirm that all of the components above continue to work as expected in all screen sizes and browsers.