fix(dropdown): Fix active index communication handled programmatically

cengage / react-magma

https://react-magma.cengage.com

MIT License

21 stars 13 forks source link

fix(dropdown): Fix active index communication handled programmatically #1455

Closed artemtrusov-cengage closed 1 month ago

artemtrusov-cengage commented 1 month ago

Issue: #1439

What I did

The menuitem role does not support aria-selected, so as an alternative, aria-checked was added to facilitate programmatic communication of the active item and to improve accessibility.

Screenshots:

Checklist

[x] changeset has been added
[x] Pull request description is descriptive
[ ] I have made corresponding changes to the documentation
[x] New and existing unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works

How to test

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: bd5ee0c8bc6b0a4eea584395d25e9d3ccb8f4d13

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

🚀 Deployed on https://docs-preview-1455--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] commented 1 month ago

🚀 Deployed on https://storybook-preview-1455--upbeat-sinoussi-f675aa.netlify.app

silvalaura commented 1 month ago

This looks good to me, but I am triple checking with our accessibility team to make sure this is the right solution. Lets hold off on merging until we get confirmation.