cengage / react-magma

https://react-magma.cengage.com
MIT License
21 stars 13 forks source link

feat(Input): Update colors for error message, icon and border in dark mode. #1501

Closed nikitaorliak-cengage closed 3 weeks ago

nikitaorliak-cengage commented 1 month ago

Issue: #1423

What I did

Update colors for error message, icon and border in dark mode.

Screenshots:

Checklist

How to test

Open Input -> Set dark mode (isInverse prop) -> Add error message -> Check message, icon, and border colors.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 823dcfe75abeed98ce4db83d74adf6b15ac2dd7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------- | ----- | | react-magma-dom | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

🚀 Deployed on https://docs-preview-1501--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] commented 1 month ago

🚀 Deployed on https://storybook-preview-1501--upbeat-sinoussi-f675aa.netlify.app

orion-cengage commented 3 weeks ago

After reviewing it, I see the same thing Laura does. In addition to the inputs that Laura listed that still need to be updated, I also believe File Uploader (Dropzone) still needs to be updated.

image

github-actions[bot] commented 3 weeks ago

🚀 Deployed on https://docs-preview-1501--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] commented 3 weeks ago

🚀 Deployed on https://storybook-preview-1501--upbeat-sinoussi-f675aa.netlify.app