cengage / react-magma

https://react-magma.cengage.com
MIT License
21 stars 13 forks source link

fix(Tag): Update tag focus state #1582

Closed silvalaura closed 2 days ago

silvalaura commented 2 days ago

Issue: none

What I did

I noticed that clickable and deletable tags had been accidentally updated to have the offset of -1, so I updated them to have the correct 2px offset, and also to use the correct focus color. While I was there, I updated the stories on storybook to be less repetitive and added unit tests.

Screenshots:

Before: image image

After: image image

Checklist

How to test

Navigate to storybook and ensure that clickable tags have the expected focus state for both isInverse and default. Also ensure the other tags don't get a focus state.

changeset-bot[bot] commented 2 days ago

🦋 Changeset detected

Latest commit: 40ea73b750f820e1c273cd004d207be477eaf741

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------- | ----- | | react-magma-dom | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 days ago

🚀 Deployed on https://docs-preview-1582--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] commented 2 days ago

🚀 Deployed on https://storybook-preview-1582--upbeat-sinoussi-f675aa.netlify.app

nikitaorliak-cengage commented 1 day ago

Cases that have been tested: