cenk1cenk2 / docker-softether-vpnsrv

SoftEther VPN Server with DNSMASQ DHCP Server or bridge mode connection for VPN-to-site setup.
29 stars 15 forks source link

Experimental build #31

Closed dormancygrace closed 1 year ago

dormancygrace commented 1 year ago

Hi. Me, again. Can you make experimental build, based on Ubuntu/OracleLinux instead of Alpine?

dormancygrace commented 1 year ago

https://github.com/cenk1cenk2/docker-softether-vpnsrv/pull/33

cenk1cenk2 commented 1 year ago

hey @dormancygrace i can merge this in tomorrow evening but wouldnt it be better with debian slim due to size, is there any particular reason for ubuntu.

maybe i should refactor the main dockerfiles to multisage ones too, seeing yours made me realize how lazy i have been throughout years

dormancygrace commented 1 year ago

I'll try with debian, but final image on Ubuntu just near 130 MB (arm64).

And I think I can further optimize Dockerfile. I want to try make static build

dormancygrace commented 1 year ago

If you make multistage build, then you can build go part in container too. My Dockerfile is just yours, adopted to Ubuntu. We can skip make install option for sure

cenk1cenk2 commented 1 year ago

Ubuntu arm64 version fails very interestingly while doing the library patch since there is a problem on the upstream side with arm detection, I have no idea why Alpine passes and this fails where they both use sh at the build. https://gitlab.kilic.dev/docker/softether-vpnsrv/-/jobs/46525#L3172

I am mostly braindead for today, if you want to have a go at it the idea is you can do that on the docker-compose file by changing the TARGETARCH to arm64 and wait for the echo to happen normally.

dormancygrace commented 1 year ago

Strange, I've built it without any problems https://hub.docker.com/r/dormancygrace/softether

dormancygrace commented 1 year ago

Where is git clone $repository? )

dormancygrace commented 1 year ago

And why there is apt-get in dockerfile?

dormancygrace commented 1 year ago

I'll try tomorrow further optimize Dockerfiles. We can skip "make install" step. For submodules init and update better to use git submodule update --init --recursive

cenk1cenk2 commented 1 year ago

Where is git clone $repository? )

I wanted to give a try to experimental synatx where it would automatically cache the sha hopefully so it would rebuild on repository change.

But didnt get the chance to test it since it could not push images yet.

cenk1cenk2 commented 1 year ago

This took some effort and had to build all my builder images as ARM too and I started to natively build the arm64 images on Oracle Cloud instead of emulating for an hour to produce as per your guidance. Still, it is now available for both Alpine and ubuntu.

https://hub.docker.com/r/cenk1cenk2/softether-vpnsrv/tags

dormancygrace commented 1 year ago

🍻 mazel tov!

P.S.: what OS you use on Oracle instance? If you don't mind, please, contact me via email "nickname"@gmail.com