cenkalti / kuyruk

⚙️ Simple task queue for Python
https://kuyruk.readthedocs.org/
MIT License
234 stars 17 forks source link

Add requirements folder #38

Closed muraty closed 9 years ago

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 84.68% when pulling 0535debd8eed7ef8eb6bfe03da82cbbf40f85b56 on muraty:requirements_folder into 5713fc1978f2ce141e40cde88ba54847283f4638 on cenkalti:master.

cenkalti commented 9 years ago

What's the benefit of putting requirements files into a folder, can you explain?

muraty commented 9 years ago

requirements folder usage is suggested (for example in the book 'two scoops of django') for putting all the requirements text files (local, base, dev, prod, test etc.) under it. It is just a notation I try to apply in my projects. There won't be any real benefit with using it, just a notation.

If you are not agree with me, you can simply decline this pr.

cenkalti commented 9 years ago

Keeping the requirements.txt file in the project root is more widely accepted convention. Here is an example from that book's repo: https://github.com/twoscoops/django-twoscoops-project/blob/develop/requirements.txt

Also I have a similar service (http://www.pypi-notifier.org) that requires requirements.txt files at the root.

muraty commented 9 years ago

Thanks for the explanation. But, I guess, I am missing the point. In the above link, the project is still using requirements folder. It keeps requirements.txt file for just those type of services; "..because many Platforms as a Service look for requirements.txt in the root directory of a project." and that file links the files under requirements folder.

So, the usage of current requirements_*.txt files at the root level is not applying the convention ?