search

cenkalti / kuyruk

⚙️ Simple task queue for Python
https://kuyruk.readthedocs.org/
MIT License
231 stars 17 forks source link

Added Windows support (at the cost of disabling some features) #55

Closed frol closed 6 years ago

frol commented 6 years ago

Closes #54 (read more about the problems and the compromises there)

I have tested it on my Windows server and it works fine there. There should be no change on Linux/MacOS.

cenkalti commented 6 years ago

@frol Do you know why the Travis build fail?

frol commented 6 years ago

I have no idea. My change should not affect any platform but Windows.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.05%) to 91.888% when pulling 3e3df24100de7651d3164b9efd733a4d298f2820 on frol:windows-support into 4c36fbb0bf408c0321b7757d61c0d6004adcb108 on cenkalti:master.

frol commented 6 years ago

@cenkalti The failing test is not related to my changes because I can reproduce it on the latest 8.4.0 commit. For some reason, RabbitMQ returns an empty list ([]) on /api/connections request if there is no delay (or delay < 5 seconds) after worker start. I couldn't come up with anything but putting a sleep before drop_connection. The failing tests on Python 3.5 are even more mysterious, I have no clue what is wrong there :(

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.05%) to 91.888% when pulling 3e3df24100de7651d3164b9efd733a4d298f2820 on frol:windows-support into 4c36fbb0bf408c0321b7757d61c0d6004adcb108 on cenkalti:master.

cenkalti commented 6 years ago

Hi @frol. Thank you for investigating the issue with tests. I think tests are not reliable because when I restarted the build on Travis, they completed successfully. Hence, I will be cherry-picking only the first commit from this PR.

cenkalti commented 6 years ago

Released a new version: https://pypi.python.org/pypi/Kuyruk/8.5.0

frol commented 6 years ago

Thank you!