Closed datashaman closed 8 years ago
I have added a method for deleting multiple files and transfers: https://github.com/cenkalti/putio.py/commit/16b33e0f97d66c46b6edf2bb19e3a4c3d3c9b515
Uploaded new version to PyPI. I hope everything is okay on your side.
Sweet! I'll test it out now.
The only problem I can see is that neither _multi method turns the integer IDs into strings, so it fails if you use the IDs from the transfer payload (which are integers)
I can work around it, but it would be nice to have that fix back:
"transfer_ids": ','.join([ str(t.id) for t in transfer_ids ])
On 26 February 2016 at 17:35, Marlin Forbes marlinf@datashaman.com wrote:
The only problem I can see is that neither _multi method turns the integer IDs into strings, so it fails if you use the IDs from the transfer payload (which are integers)
Also, including 500 may cause unnecessary retries, but I'll let you know if i experience problems.
On 26 February 2016 at 17:37, Marlin Forbes marlinf@datashaman.com wrote:
I can work around it, but it would be nice to have that fix back:
"transfer_ids": ','.join([ str(t.id) for t in transfer_ids ])
On 26 February 2016 at 17:35, Marlin Forbes marlinf@datashaman.com wrote:
The only problem I can see is that neither _multi method turns the integer IDs into strings, so it fails if you use the IDs from the transfer payload (which are integers)
Whoot! Got my first release out, thanks for your help!
https://github.com/datashaman/putio-automator/releases/tag/0.1.0
On 26 February 2016 at 17:48, Marlin Forbes marlinf@datashaman.com wrote:
Also, including 500 may cause unnecessary retries, but I'll let you know if i experience problems.
On 26 February 2016 at 17:37, Marlin Forbes marlinf@datashaman.com wrote:
I can work around it, but it would be nice to have that fix back:
"transfer_ids": ','.join([ str(t.id) for t in transfer_ids ])
On 26 February 2016 at 17:35, Marlin Forbes marlinf@datashaman.com wrote:
The only problem I can see is that neither _multi method turns the integer IDs into strings, so it fails if you use the IDs from the transfer payload (which are integers)
I notice you don't tag your releases. It is std practice on each release to tag the master branch with the release number. It is quite useful to easily go back to a specific release to see the differences, and allows users of your library to select specific versions to use on github (if they don't use PyPI eggs).
Have a look at this for a good branching and releasing strategy:
http://nvie.com/posts/a-successful-git-branching-model/ https://github.com/nvie/gitflow
On 26 February 2016 at 18:17, Marlin Forbes marlinf@datashaman.com wrote:
Whoot! Got my first release out, thanks for your help!
https://github.com/datashaman/putio-automator/releases/tag/0.1.0
On 26 February 2016 at 17:48, Marlin Forbes marlinf@datashaman.com wrote:
Also, including 500 may cause unnecessary retries, but I'll let you know if i experience problems.
On 26 February 2016 at 17:37, Marlin Forbes marlinf@datashaman.com wrote:
I can work around it, but it would be nice to have that fix back:
"transfer_ids": ','.join([ str(t.id) for t in transfer_ids ])
On 26 February 2016 at 17:35, Marlin Forbes marlinf@datashaman.com wrote:
The only problem I can see is that neither _multi method turns the integer IDs into strings, so it fails if you use the IDs from the transfer payload (which are integers)
Fixed the issue with _multi()
methods and uploaded the new version to PyPI. Thanks for reporting this.
genius use of map. doh! :)
On 27 February 2016 at 00:23, Cenk Altı notifications@github.com wrote:
Fixed the issue with _multi() methods and uploaded the new version to PyPI. Thanks for reporting this.
— Reply to this email directly or view it on GitHub https://github.com/cenkalti/putio.py/pull/20#issuecomment-189507183.
Various changes for your PR