Refactor Doughnut for 2.0 Changes

jordy25519 commented 5 years ago

Change Summary

Introduce RawOrigin::Delegated(AccountId, Doughnut) to allow passing the doughnut proof to runtime methods and ensuring delegation is known at all times by the runtime.
Use the SignedExtension feature of transactions to handle doughnut logic, removed form executive

Closes #46 and 90% of groundwork for https://github.com/cennznet/cennznet/issues/54

TODO

[x] Fix srml/support tests
[x] Reinstate executive tests?
[x] Integration tests for delegated transactions
[ ] Fix prml-doughnut tests with cargo test --all

ChangeLog

Files: core/sr-primitives/src/traits.rs

Blanket impl SignedExtension for Option<T>
MaybeDoughnut trait for extracting doughnut from SignedExtra tuple
impl MaybeDoughnut for SignedExtension macro tuple of all lengths
Changed trait SignedExtension::pre_dispatch to take self by reference (&self), not move (self)

Files: srml/system/src/lib.rs and srml/support/src/origin.rs

Add DelegatedOrigin variant (AccountId, Doughnut)
Add MaybeDoughnutRef trait for extracting doughnut from origin without move in runtime methods
Improve doughnut type bounds type Doughnut: Parameter + Member + DoughnutApi;

Files: srml/executive

Remove DoughnutExecutive, it has been superseded by the hooks provided by SignedExtensiontrait.

Files: node/runtime/src/lib.rs

DelegatedOrigin type, it's now necessary as the context storage hack is outside of the executive/runtime and won't work anymore
Removed node/runtime/src/doughnut.rs, moved into prml/doughnut

Files: prml/doughnut Adds:

Add PlugDoughnut as wrapper struct for doughnut to use new tx SignedExtension
Add PlugDoughnutDispatcher and impl for DispatchVerifier
impl DoughnutVerify for PlugDoughnut
impl SignedExtension for PlugDoughnut

Files: node/primitives/plug_extrinsic.rs

Removed, now using SignedExtension functionality

shaunxw commented 5 years ago

Has CI been turned off?

cowboy-bebug commented 5 years ago

Has CI been turned off?

I think it's running. Looks like it's been running for > 1 hr 😄

shaunxw commented 5 years ago

Has CI been turned off?

I think it's running. Looks like it's been running for > 1 hr 😄

Wired, didn't see any CI building status on this page - -

cowboy-bebug commented 5 years ago

@holygits reasons why the tests are failing could be due to version mismatch between doughnut and the substrate. For example schnorrkel v0.1.x for doughnut vs 0.8.4 on substrate. I did notice our tests failing on doughnut-rs when I bumped up this crate

https://github.com/cennznet/doughnut-rs/issues/11#issuecomment-540338294

jordy25519 commented 5 years ago

Fixed the tests in this branch + substrate updates from #49 : https://github.com/cennznet/plug-blockchain/tree/develop

jordy25519 commented 5 years ago

Superseded by https://github.com/cennznet/plug-blockchain/tree/develop

cennznet / plug-blockchain