search

cennznet / plug-blockchain

PL^G: a framework for building customised blockchains
GNU General Public License v3.0
11 stars 3 forks source link

Issue/hotfix/#63 #64

Closed mzxyz closed 4 years ago

mzxyz commented 4 years ago

63

jordy25519 commented 4 years ago

https://github.com/cennznet/plug-blockchain/blob/96c80bfa67f9b511b560d2468b355253e9f46a4c/core/peerset/src/lib.rs#L679 This line is a compile error. peer_id hasn't been declared change tobootnode

cowboy-bebug commented 4 years ago

I think it should be reserved_peer

 peerset.incoming(reserved_peer.clone(), IncomingIndex(1));

test fail with the above change 😆

---- tests::test_peerset_reserved_node_not_banned stdout ----
thread 'tests::test_peerset_reserved_node_not_banned' panicked at 'assertion failed: `(left == right)`
  left: `Ready(Some(Connect(PeerId("QmVEr8KUCkhAu26FQdBLempHqgkZheXHZsYPL9mBQT2Uq3"))))`,
 right: `Pending`', core/peerset/src/lib.rs:676:4
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.