search

cenotelie / hime

Apache License 2.0
27 stars 4 forks source link

Compression support is currently broken and should be marked as experimental #89

Open stevefan1999-personal opened 1 year ago

stevefan1999-personal commented 1 year ago

It seems like clarify option names in CompilationTask and expose them in CLI · 95d675c (github.com) has broken the compression support.

Currently I forked include-flate and added a bit of a syntax to support loading files with a base directory from environmental variables, the PR is over at Allow user input environmental variables as base path by stevefan1999-personal · Pull Request #21 · SOF3/include-flate (github.com).

The syntax should looks like this

include_flate::flate!(static LEXER_AUTOMATON: [u8] from "{}" on "OUT_DIR");

Notice the new on "OUT_DIR" here. Maybe we should explicitly use this in Hime.

stevefan1999-personal commented 1 year ago

Hmm, maybe it is really a me problem. I'm invoking Hime directly on build.rs, and obviously I would like to see the generated files at OUT_DIR, just like bindgen. Maybe we should retrofit this new syntax with a flag.

woutersl commented 1 year ago

If it's not too much of an inconvenience, I think the best course of actions is to wait for your PR on include-flate to be merged and a version published. Then we will bump the dependency in Hime and use the new feature.