search

cenpy-devs / cenpy

Explore and download data from Census APIs
Other
183 stars 44 forks source link

Documentation includes extraneous detail for decennial.from_state #77

Open ljwolf opened 5 years ago

ljwolf commented 5 years ago

the docstring still includes information about a state_type specifier. This is because I'm just swapping strings place for state when building the docstring.

However, this option isn't supported, since there aren't different types of states in the census API.

This needs to be fixed probably across all docstrings that share this skeleton.

jGaboardi commented 4 years ago

the docstring still includes information about a state_type specifier. This is because I'm just swapping strings place for state when building the docstring.

However, this option isn't supported, since there aren't different types of states in the census API.

This needs to be fixed probably across all docstrings that share this skeleton.

Reading over your description, this doesn't seem all that complicated, but for some reason I am having trouble wrapping my head around it. Though/advice for a PR?

Also, from #76:

A simple way to actually solve this issue would be:

  1. check if the input string is exactly 2 characters long and,
  2. use only the abbreviations in _fuzzy_match

Do you mean only checking the postal abbreviation here?