censhuyi
commented
2 years ago Thank you so much for giving me the feedback so detailed.
Get Outlook for iOShttps://aka.ms/o0ukef
From: Phil Sinatra @.> Sent: Wednesday, October 19, 2022 5:10:26 PM To: censhuyi/Shuyi-Cen-Portfolio @.> Cc: Subscribed @.***> Subject: [censhuyi/Shuyi-Cen-Portfolio] Midterm feedback (Issue #1)
External.
File names
All of your file names should be lowercase and not contain spaces or special characters.
- About me.html
- about_me.html
File structure
You have what looks like two full HTML documents in a single filehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcenshuyi%2FShuyi-Cen-Portfolio%2Fblob%2F7d1fa2cc8d3ad09455594ad1f5d7e2a2daec9764%2FInterior%2520Design.html%23L30&data=05%7C01%7Csc3948%40drexel.edu%7C6c6be75babdc40ed403e08dab2165853%7C3664e6fa47bd45a696708c4f080f8ca6%7C0%7C0%7C638018106293116395%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=6NKlV%2Bvoi3OyG4Pb3iNc5%2BYlk%2F8rmQXYbzSk9PeZFO4%3D&reserved=0
Depreciated tag
The center elementhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdeveloper.mozilla.org%2Fen-US%2Fdocs%2FWeb%2FHTML%2FElement%2Fcenter&data=05%7C01%7Csc3948%40drexel.edu%7C6c6be75babdc40ed403e08dab2165853%7C3664e6fa47bd45a696708c4f080f8ca6%7C0%7C0%7C638018106293272630%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=btqHwFOfPldMmR8MzPGJ2i5rpSvLYEXboankuyUgoI8%3D&reserved=0 is deprecated and should not be usedhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcenshuyi%2FShuyi-Cen-Portfolio%2Fblob%2F7d1fa2cc8d3ad09455594ad1f5d7e2a2daec9764%2Fdrawings.html%23L16&data=05%7C01%7Csc3948%40drexel.edu%7C6c6be75babdc40ed403e08dab2165853%7C3664e6fa47bd45a696708c4f080f8ca6%7C0%7C0%7C638018106293272630%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MSChip7YMhn%2BqiTSDtfjU5nEn%2BiJRwiF7kV1BuKP2U0%3D&reserved=0. We'll learn how to center content in class.
Bad anchor attribute value
href values that point to other files (instead of linking to sections in the same file) should not include the hashtaghttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcenshuyi%2FShuyi-Cen-Portfolio%2Fblob%2F7d1fa2cc8d3ad09455594ad1f5d7e2a2daec9764%2FInterior%2520Design.html%23L16&data=05%7C01%7Csc3948%40drexel.edu%7C6c6be75babdc40ed403e08dab2165853%7C3664e6fa47bd45a696708c4f080f8ca6%7C0%7C0%7C638018106293272630%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=wwOdpGeOS2ZcYIcezSo1mSozo3jh8zZvelIq2PBH2VI%3D&reserved=0.
— Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcenshuyi%2FShuyi-Cen-Portfolio%2Fissues%2F1&data=05%7C01%7Csc3948%40drexel.edu%7C6c6be75babdc40ed403e08dab2165853%7C3664e6fa47bd45a696708c4f080f8ca6%7C0%7C0%7C638018106293272630%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=8rIdsXqrvs3AEbkAIkSxszOkH5uCKgHYEgfWR1tmDmQ%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA3ICIFWS35YW667RI4FFXCLWEBPUFANCNFSM6AAAAAARJQNEEQ&data=05%7C01%7Csc3948%40drexel.edu%7C6c6be75babdc40ed403e08dab2165853%7C3664e6fa47bd45a696708c4f080f8ca6%7C0%7C0%7C638018106293272630%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Dw9S69zADHEws0uMfD%2BgUon1d3rkVw3OOPTnITNDM5I%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.***>
File names
All of your file names should be lowercase and not contain spaces or special characters.
File structure
You have what looks like two full HTML documents in a single file
Depreciated tag
The center element is deprecated and should not be used. We'll learn how to center content in class.
Bad anchor attribute value
hrefvalues that point to other files (instead of linking to sections in the same file) should not include the hashtag.