search

censorship-no-archive / ceno1

(Deprecated PoC) Innovative censorship evading technology based on p2p distributed caching network
https://censorship.no
GNU Affero General Public License v3.0
58 stars 14 forks source link

Bundle-Server panic when preparing readability version of a bundle #141

Closed misaakidis closed 8 years ago

misaakidis commented 8 years ago

As a bridge owner I want agents to be handling internal errors gracefully, so if preparing and inserting a bundle fails, the agents will log it and move on to the next bundle.

misaakidis commented 8 years ago

RSS-Reader log:

Get http://127.0.0.1:3094/?url=aHR0cDovL3d3dy5mYXJzbmV3cy5jb20vMTM5NDA4MjcwMDA4OTg=: EOF
Nov 11, 2015 16:23:54:584 Failed to created a bundle for http://www.farsnews.com/13940827000898.
Error making request
Get http://127.0.0.1:3094/?url=aHR0cDovL3d3dy5mYXJzbmV3cy5jb20vMTM5NDA4MjcwMDEzNzI=: dial tcp 127.0.0.1:3094: connection refused
Nov 11, 2015 16:23:54:585 Failed to created a bundle for http://www.farsnews.com/13940827001372.

Bundle-Server log:

Making bundler for http://www.farsnews.com/13940827000898
Request is from RSS Reader? true
Making a readable page.
info: Making request with options:  url=http://www.farsnews.com/shares/img/photologo.jpg, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/facebook.png, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/twitter.png, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/gplus.png, encoding=null
info: Making request with options:  url=http://media.farsnews.com/media/Uploaded/Files/Images/1394/08/27/13940827000575_PhotoG.jpg, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/viewcount.png, encoding=null
info: Making request with options:  url=http://media.farsnews.com/media/Uploaded/Files/Images/1394/08/26/13940826000520_PhotoG.jpg, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/viewcount.png, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/medpagearr.png, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/comnttopeff.png, encoding=null
info: Making request with options:  url=http://media.farsnews.com/media/Uploaded/Files/Images/1394/08/10/13940810000741_PhotoG.jpg, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/time.png, encoding=null
info: Making request with options:  url=http://media.farsnews.com/media/Uploaded/Files/Images/1394/08/27/13940827000575_PhotoG.jpg, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/time.png, encoding=null
info: Making request with options:  url=http://media.farsnews.com/media/Uploaded/Files/Images/1394/08/26/13940826001073_PhotoG.jpg, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/time.png, encoding=null
info: Making request with options:  url=http://media.farsnews.com/media/Uploaded/Files/Images/1394/08/26/13940826000764_PhotoG.jpg, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/time.png, encoding=null
info: Making request with options:  url=http://media.farsnews.com/media/Uploaded/Files/Images/1394/08/27/13940827000185_PhotoG.jpg, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/time.png, encoding=null
info: Making request with options:  url=http://media.farsnews.com/media/Uploaded/Files/Images/1394/08/27/13940827000200_PhotoG.jpg, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/time.png, encoding=null
info: Making request with options:  url=http://media.farsnews.com/media/Uploaded/Files/Images/1394/08/23/13940823000702_PhotoG.jpg, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/time.png, encoding=null
info: Making request with options:  url=http://media.farsnews.com/media/Uploaded/Files/Images/1394/08/27/13940827000182_PhotoG.jpg, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/time.png, encoding=null
info: Making request with options:  url=http://media.farsnews.com/media/Uploaded/Files/Images/1394/08/25/13940825000274_PhotoG.jpg, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/time.png, encoding=null
info: Making request with options:  url=http://media.farsnews.com/media/Uploaded/Files/Images/1394/08/26/13940826000520_PhotoG.jpg, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/time.png, encoding=null
info: Making request with options:  url=http://media.farsnews.com/media/Uploaded/Files/Images/1394/08/26/13940826000954_PhotoG.jpg, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/time.png, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/Footer/rss.png, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/Footer/gplus.png, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/Footer/ins.png, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/mobileIcon.png, encoding=null
info: Making request with options:  url=http://www.farsnews.com/shares/img/Footer/Logo.png, encoding=null
arcrose commented 8 years ago

@misaakidis Could I ask you to see if the bug is resolved in the issue141 branch if you re-run npm install with the Node LTS release (node 4.2 and corresponding NPM)?

I'm just not encountering the bug.

misaakidis commented 8 years ago

@redwire not able to reproduce. But could we please add code to gracefully catch exceptions in readability library, so as to ensure that bundle-server won't panic in the future?