search

census-ecosystem / opencensus-go-exporter-stackdriver

OpenCensus Go exporter for Stackdriver Monitoring and Trace
Apache License 2.0
67 stars 79 forks source link

Use standard label name for location. #241

Closed jkohen closed 4 years ago

jkohen commented 4 years ago

The location label is required. The resource type mappings defined in resource.go uniformly expect resourcekeys.CloudKeyZone, except the generic_task, but there is no good reason for that, as Stackdriver still requires a valid cloud location for generic_task. Therefore, use a cloud location everywhere.

This makes the exporter work out-of-the-box in conjuction with kubernetes-operator and partially addresses https://github.com/census-ecosystem/kubernetes-operator/issues/14

@rghetia please review.

codecov-io commented 4 years ago

Codecov Report

Merging #241 into master will decrease coverage by 0.09%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #241     +/-   ##
=========================================
- Coverage   73.28%   73.19%   -0.1%     
=========================================
  Files          14       14             
  Lines        1617     1619      +2     
=========================================
  Hits         1185     1185             
- Misses        356      358      +2     
  Partials       76       76
Impacted Files Coverage Δ
resource.go 100% <ø> (ø) :arrow_up:
stackdriver.go 32.32% <0%> (-0.67%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59d068f...2bb7758. Read the comment docs.