nicktrav commented 4 years ago

In situations where a large number of spans need to be exported from a single instance of the exporter, bundle uploads are limited to using a single goroutine. This limits the overall throughput of the exporter.

Make use of the NumberOfWorkers option to allow the exporter to use multiple, concurrent goroutines to upload spans to Stackdriver.

Closes #245.

Signed-off-by: Nick Travers n.e.travers@gmail.com

codecov-io commented 4 years ago

Codecov Report

Merging #246 into master will increase coverage by 0.03%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
+ Coverage   73.19%   73.22%   +0.03%     
==========================================
  Files          14       14              
  Lines        1619     1621       +2     
==========================================
+ Hits         1185     1187       +2     
  Misses        358      358              
  Partials       76       76

Impacted Files	Coverage Δ
stackdriver.go	`32.32% <ø> (ø)`	:arrow_up:
trace.go	`60% <100%> (+0.9%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1cdca91...2c45202. Read the comment docs.

nicktrav commented 4 years ago

cc: @songy23 @rghetia - would you be able to help me get a review on this?

nicktrav commented 4 years ago

@songy23 - thanks for the review. Should be good for another pass.

nicktrav commented 4 years ago

@songy23 - cool to land this one?

nicktrav commented 4 years ago

@rghetia - thanks for merging. Any chance of a release?

rghetia commented 4 years ago

@rghetia - thanks for merging. Any chance of a release?

sure, after #248.

rghetia commented 4 years ago

@nicktrav released v0.12.9

census-ecosystem / opencensus-go-exporter-stackdriver

trace: allow for concurrent uploads to Stackdriver #246

Codecov Report