Closed laoj2 closed 2 years ago
/gcbrun
Copy-pasting build errors for easy reference:
staticcheck ./...
metrics_test.go:23:2: package github.com/golang/protobuf/ptypes is deprecated: Well-known types have specialized functionality directly injected into the generated packages for each message type. See the deprecation notice for each function for the suggested alternative. (SA1019)
metrics_test.go:94:18: ptypes.Timestamp is deprecated: Call the ts.AsTime and ts.CheckValid methods instead. (SA1019)
metrics_test.go:99:16: ptypes.Timestamp is deprecated: Call the ts.AsTime and ts.CheckValid methods instead. (SA1019)
metrics_test.go:435:18: ptypes.Timestamp is deprecated: Call the ts.AsTime and ts.CheckValid methods instead. (SA1019)
metrics_test.go:440:16: ptypes.Timestamp is deprecated: Call the ts.AsTime and ts.CheckValid methods instead. (SA1019)
metrics_test.go:569:18: ptypes.Timestamp is deprecated: Call the ts.AsTime and ts.CheckValid methods instead. (SA1019)
metrics_test.go:574:16: ptypes.Timestamp is deprecated: Call the ts.AsTime and ts.CheckValid methods instead. (SA1019)
stats_test.go:26:2: package github.com/golang/protobuf/ptypes is deprecated: Well-known types have specialized functionality directly injected into the generated packages for each message type. See the deprecation notice for each function for the suggested alternative. (SA1019)
stats_test.go:503:16: ptypes.Timestamp is deprecated: Call the ts.AsTime and ts.CheckValid methods instead. (SA1019)
stats_test.go:508:14: ptypes.Timestamp is deprecated: Call the ts.AsTime and ts.CheckValid methods instead. (SA1019)
/gcbrun
/gcbrun
I discussed this offline with @dashpole and @csbell and we've decided to split the requests into 2 (one with only service metrics, the other one with the rest of the metrics). @dashpole can you PTAL?
EDIT: I still want to add more tests to stackdriver/metrics.go, but early feedback is appreciated. Thanks :))