census-ecosystem / opencensus-ruby-exporter-stackdriver

OpenCensus Ruby exporters for Google Stackdriver
Apache License 2.0
9 stars 11 forks source link

Reflect min and max thread size #15

Closed munisystem closed 6 years ago

munisystem commented 6 years ago

The current implementation can't reflect min and max thread size in Concurrent::ThreadPoolExecutor. Because of that, it creates a new thread whenever exporting spans.

This PR fixed mistaking keyword arguments.

munisystem commented 6 years ago

The failing tests have no concern for this PR. I fixed it at #16

bogdandrutu commented 6 years ago

Please rebase.

munisystem commented 6 years ago

Thanks :)