search

census-instrumentation / opencensus-csharp

Distributed tracing and stats collecting framework
https://opencensus.io
Apache License 2.0
139 stars 32 forks source link

Adds MVC middleware for Prometheus Exporter. #103

Closed orthros closed 5 years ago

orthros commented 5 years ago

Refactors the writing of metrics to a common utility class in Implementation.

Removes the assembly: System.CLSCompliant(true)] directive from OpenCensus.Exporter.Prometheus to allow support for non-CLS code (which are the MVC types).

Adds a test/example Application, TestPrometheusMiddleware.AspNetCore.2.0, which shows the middleware working in an example MVC application.

Closes #65

ekarlso commented 5 years ago

Hi, any news on getting this in ?

simonz130 commented 5 years ago

I suspect that in one of the upcoming Fridays there will be progress here @orthros, please correct me if I'm wrong :)

orthros commented 5 years ago

@simonz130 You are correct! I've been backlogged with travel of late 😅.

I currently have some in-progress changes to add tests, and some small restructuring of the solution. Hope to get this up and running soon!

ekarlso commented 5 years ago

@orthros can we please get this in ?

ekarlso commented 5 years ago

@orthros any idea on getting this in ?

SergeyKanzhelev commented 5 years ago

@orthros can you please resubmit it here: https://github.com/open-telemetry/opentelemetry-dotnet