search

census-instrumentation / opencensus-csharp

Distributed tracing and stats collecting framework
https://opencensus.io
Apache License 2.0
139 stars 32 forks source link

ToSpanData may be implemented as a wrapper object with a single allocation instead of copying everything #134

Closed SergeyKanzhelev closed 5 years ago

SergeyKanzhelev commented 5 years ago

There are scenarios when span informaiton is needed in End callback to populate tracestate and things like this. For this quicker access to spandata may be needed.

We should not simply open Span setters as we want to discourage using span as attributes propagation mechanism

SergeyKanzhelev commented 5 years ago

This will be handled in OpenTelemetry project if this will still be an issue. See the linked issue on specs: https://github.com/open-telemetry/opentelemetry-specification/issues/60