census-instrumentation / opencensus-csharp

Distributed tracing and stats collecting framework
https://opencensus.io
Apache License 2.0
139 stars 32 forks source link

Fix for loading GOOGLE_APPLICATION_CREDENTIALS json key file from read-only volumes #146

Closed marklonquist closed 5 years ago

marklonquist commented 5 years ago

This pull request fixes an issue where the GOOGLE_APPLICATION_CREDENTIALS json key file might be on a read-only volume, which can make it throw System.IO.IOException. Setting the FileAccess.Read fixes this.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

marklonquist commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.