search

census-instrumentation / opencensus-go

A stats collection and distributed tracing framework
http://opencensus.io
Apache License 2.0
2.06k stars 327 forks source link

Runmetrics: Expand to Include GC Stats #1188

Open dm03514 opened 4 years ago

dm03514 commented 4 years ago

Is your feature request related to a problem? Please describe. Greetings! I just started using opencensus in go. The quality and framework was super easy to use, the primitives are intuitive and there are great docs! One thing I noticed was that runtime (runmetrics) metrics didn't include GC information. I'm wondering if runmetrics are a good place to include these metrics?

Describe the solution you'd like If runmetrics is a good place to include these metrics, I was hoping to have gc stats included in the runtime metrics exported.

Describe alternatives you've considered I could pretty easily instrument these in my own application, even package it as a library so all my go apps could easily get these metrics.

Additional context

This request is based on the runtime metrics that prometheus go client ships with.

Can see the prometheus metrics in action on their grafana dashboard:

go_processes

Thank you!!!

dm03514 commented 4 years ago

If you're open to this, I'd be happy to contribute it

rghetia commented 4 years ago

If you're open to this, I'd be happy to contribute it (will try and tackle it next week)

sure.

hougaardj commented 3 years ago

Any idea when/if the pull request will be merged? The GC metrics are very useful to have.

punya commented 3 years ago

@hougaardj I just merged the PR. Are you able to test it out from the master branch, or do you need a tagged RC?

hougaardj commented 3 years ago

Thank you for the quick turn around :)

I have tested it from master branch and i got the additional metrics. I do need a tagged release to start using it proper.

hougaardj commented 3 years ago

@punya Can we create a release?

punya commented 3 years ago

@hougaardj we just published v0.23.0 (release notes).