search

census-instrumentation / opencensus-go

A stats collection and distributed tracing framework
http://opencensus.io
Apache License 2.0
2.05k stars 326 forks source link

GRPC Plugin Reports server/client CompletedRpcs to Latency Measure #1214

Closed smhendrickson closed 4 years ago

smhendrickson commented 4 years ago

This can be found in master: https://github.com/census-instrumentation/opencensus-go/blob/master/plugin/ocgrpc/client_metrics.go#L64 https://github.com/census-instrumentation/opencensus-go/blob/master/plugin/ocgrpc/server_metrics.go#L67

Smells like a typo? If so, I'm happy to provide a PR.

AIUI the process should be just adding a new stats var, and fixup tests: https://github.com/census-instrumentation/opencensus-go/blob/master/plugin/ocgrpc/server_metrics.go#L25-L31

james-bebbington commented 4 years ago

Yes, this definitely looks like a typo. Please go ahead and create a PR if you need this to be fixed.

smhendrickson commented 4 years ago

Thanks James, I've sent a PR. we can go over the details there.